igmpproxy: support new phyint options in init script - #30486
Open
RewardedIvan wants to merge 1 commit into
Open
Conversation
RewardedIvan
force-pushed
the
igmpproxy-uci
branch
from
September 8, 2026 20:00
5bb8c4c to
832aafe
Compare
openwrt-ai
reviewed
Sep 9, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Commit checks
832aafe"igmpproxy: update the uci config" — no UCI config is updated:files/igmpproxy.configis untouched, so the newratelimit/threshold/whitelist/blacklistoptions ship undocumented whilealtnetandverboseare shown there. Add them to the sample config, or retitle to describe the init-script change.832aafebody —thresholdis also made configurable but is not listed; and "stopped dropping SSDP by default" describes an opt-out that remains available, whereas the diff deletes the rule with no way to re-enable it.
The three red build jobs (x86_64, arm_cortex-a15, mips_24kc) fail in the feed setup step (wget: exited with error 8 / UNTRUSTED signature fetching packages.adb), not on this package — looks like CI infrastructure, not this PR.
Generated by Claude Code
RewardedIvan
force-pushed
the
igmpproxy-uci
branch
from
September 9, 2026 15:15
832aafe to
0a94455
Compare
RewardedIvan
force-pushed
the
igmpproxy-uci
branch
from
September 9, 2026 15:16
0a94455 to
f610c34
Compare
RewardedIvan
changed the title
openwrt-ai
reviewed
Sep 10, 2026
RewardedIvan
force-pushed
the
igmpproxy-uci
branch
2 times, most recently
from
September 10, 2026 12:29
a39c97e to
225e508
Compare
openwrt-ai
reviewed
Sep 10, 2026
made ratelimit and threshold configurable added whitelist and blacklist made SSDP firewall dropping configurable increase pkg release added commented examples in the sample config for the new options Signed-off-by: Ivan Klichenko <ivan@int4.cc>
RewardedIvan
force-pushed
the
igmpproxy-uci
branch
from
September 10, 2026 18:12
225e508 to
8885ced
Compare
openwrt-ai
reviewed
Sep 10, 2026
| igmp_add_firewall_routing() { | ||
| config_get direction $1 direction | ||
| config_get zone $1 zone | ||
| config_get_bool fw_drop_ssdp $1 fw_drop_ssdp 1 |
Collaborator
There was a problem hiding this comment.
nit: the PR description still claims "stopped dropping SSDP by default", but the default here is 1, so SSDP is still dropped unless the user opts out. Update the PR body to match the commit message ("made SSDP firewall dropping configurable"); it also still omits threshold.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @nbd168
Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am