feat: Support option for padding (set all unused bit to 1)#87
Closed
wallem89 wants to merge 3 commits into
Closed
Conversation
added 2 commits
November 5, 2024 15:09
…ding-when-encoding
|
I'm also interested in this feature. Any chance we can merge this? |
trnila
reviewed
Jul 13, 2026
|
|
||
| /// Optional: Padding value used; set all unused bits to 1 if true else 0. Default: `false`. | ||
| #[builder(default)] | ||
| pub padding_value: bool, |
Member
There was a problem hiding this comment.
or padding_bit/unused_bit_value?
There was a problem hiding this comment.
Perhaps padding_bit_value would be the clearest? Since it's a Boolean, padding_bit could be confused with enabling or disabling padding instead of specifying which value we want the padding to be.
Author
There was a problem hiding this comment.
I agree and have changed the name
Author
|
Sorry I couldn't get rebase to work on this PR so I made a new one based on latest main: #184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is adding the support for padding. In other words the option to set all unused bits to
1instead of0. One use case is when creating SAE J1939 message in which all unused bits so be set to1.See also issue 86 .