Rework host commands#710
Open
jamesmunns wants to merge 3 commits into
Open
Conversation
This aims to support oxidecomputer/hubris#2518, but also remedy oxidecomputer/hubris#2586.
labbott
reviewed
Jul 2, 2026
Comment on lines
+388
to
+394
| // Work through the different places "last panic" info could be hiding | ||
| let sources: [fn(&HubrisArchive, &mut dyn Core) -> _; _] = [ | ||
| host_last_panic_packrat, | ||
| host_last_panic_spcomms_old, | ||
| |h, c| host_last_panic_spcomms_new(h, c, HOST_STATE_BUF_NAME_1), | ||
| |h, c| host_last_panic_spcomms_new(h, c, HOST_STATE_BUF_NAME_2), | ||
| ]; |
Contributor
There was a problem hiding this comment.
Is this in order of newest to oldest?
Author
There was a problem hiding this comment.
The old code did basically:
host_last_panic_spcomms_oldhost_last_panic_spcomms_new(h, c, HOST_STATE_BUF_NAME_1)
I made the executive decision to try packrat first, then the new-new spcomms last. Open to re-order this, it shouldn't be order dependent.
Comment on lines
+255
to
+258
| fn host_boot_fail_packrat( | ||
| hubris: &HubrisArchive, | ||
| core: &mut dyn Core, | ||
| ) -> Result<Option<Vec<u8>>> { |
Contributor
There was a problem hiding this comment.
I keep wishing this could share more code with host_last_panic but I think they are just enough different that would be annoying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to support oxidecomputer/hubris#2518, but also remedy oxidecomputer/hubris#2586.