Skip to content

Add --ip-pool and --ip-version to instance from-image - #1553

Merged
ahl merged 4 commits into
mainfrom
fix-1551
Sep 23, 2026
Merged

ahl merged 4 commits into
mainfrom
fix-1551

Conversation

@ahl

@ahl ahl commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Closes #1551

@ahl
ahl requested a review from paudmir September 22, 2026 22:44

let instance_response = oxide::types::Instance {
name: "bingo".parse().unwrap(),
description: "there was a farmer who had a dog".to_string(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕

}))
.external_ips(vec![ExternalIpCreate::Ephemeral {
pool_selector: oxide::types::PoolSelector::Auto {
ip_version: Some(oxide::types::IpVersion::V6),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this test make it if it runs on buildomat?
Ah! Saw it fail:

control: job assigned to worker 01M35MMWB9GQGQ63E5F241P045 [factory aws, i-03611782f7e5b2456] (queued for 51 s)
...
task: starting task 0: "setup"
task: process exited: duration 4079 ms, exit code 0
...
task: starting task 1: "rust-toolchain"
task: process exited: duration 17801 ms, exit code 0
...
task: starting task 2: "authentication"
task: process exited: duration 16 ms, exit code 0
...
task: starting task 3: "clone repository"
task: process exited: duration 3775 ms, exit code 0
...
task: starting task 4: "build"
...
| failures:
|     test_instance_from_image
| 
| test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished i [...]
| 
| error: test failed, to rerun pass `-p oxide-cli --test test_instance`
| 
| real        2.874884806
| user        1.593627332
| sys         0.511712679
| trap        0.003699352
| tflt        0.001970707
| dflt        0.000914077
| kflt        0.000001478
| lock        5.433896751
| slp        44.163986222
| lat         0.239982598
| stop        0.626513558
task: process exited: duration 175840 ms, exit code 101
|W| found 0 output files

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I forgot a file

@ahl
ahl merged commit 4f6a0e8 into main Sep 23, 2026
17 checks passed
@ahl
ahl deleted the fix-1551 branch September 23, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CmdInstanceFromImage will hardcode IPv4, which will be a hurdle for IPv6/Dual scenarios

2 participants