add SpannedString, a String that remembers its span - #232
Merged
Conversation
sunshowers
force-pushed
the
jj-stack/add-spannedstring-a-string-that-remembers-its-span-wotyuqpn
branch
from
September 2, 2026 09:01
4147f4f to
831c294
Compare
In some situations it is useful to carry around span information along with a bare `String`. There isn't really a syn type that accepts either a `LitStr` or an `Ident` the way `String` does. Introduce `SpannedString`, which acts as that type and can be used as `ParseWrapper<SpannedString>`. One alternative to this is to implement `Deserialize` on `SpannedString` directly, but error handling for that would require a third side-channel thread local on top of the two we already have. This is much more straightforward implementation-wise. (It also has a pleasing cripness -- it's easier to explain.)
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
sunshowers
force-pushed
the
jj-stack/add-spannedstring-a-string-that-remembers-its-span-wotyuqpn
branch
from
September 4, 2026 20:51
831c294 to
60ac74b
Compare
sunshowers
deleted the
jj-stack/add-spannedstring-a-string-that-remembers-its-span-wotyuqpn
branch
September 4, 2026 20:54
sunshowers
commented
Sep 4, 2026
| quote = "1.0" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| syn = { version = "3.0.2", features = ["full"] } | ||
| syn = { version = "3.0.5", features = ["full"] } |
Contributor
Author
There was a problem hiding this comment.
Bumped this up to pull in dtolnay/syn#2080.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some situations it is useful to carry around span information along with a bare
String. There isn't really a syn type that accepts either aLitStror anIdentthe wayStringdoes. IntroduceSpannedString, which acts as that type and can be used asParseWrapper<SpannedString>.One alternative to this is to implement
DeserializeonSpannedStringdirectly, but error handling for that would require a third side-channel thread local on top of the two we already have. This is much more straightforward implementation-wise. (It also has a pleasing crispness and orthogonality.)