Skip to content

feat: add roaring bitmaps in posing lists#445

Closed
cheb0 wants to merge 2 commits into
336-compactionfrom
329-lid-bitmaps
Closed

feat: add roaring bitmaps in posing lists#445
cheb0 wants to merge 2 commits into
336-compactionfrom
329-lid-bitmaps

Conversation

@cheb0

@cheb0 cheb0 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@cheb0 cheb0 changed the base branch from main to 336-compaction June 23, 2026 13:56
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.08955% with 96 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (336-compaction@04086ec). Learn more about missing BASE report.

Files with missing lines Patch % Lines
frac/sealed/lids/block.go 76.72% 30 Missing and 7 partials ⚠️
frac/sealed/lids/iterator_batched_asc.go 60.41% 12 Missing and 7 partials ⚠️
frac/sealed/lids/iterator_batched_desc.go 70.83% 9 Missing and 5 partials ⚠️
cmd/index_analyzer/main.go 0.00% 10 Missing ⚠️
node/batch.go 96.12% 6 Missing ⚠️
frac/sealed/lids/iterator_asc.go 91.48% 2 Missing and 2 partials ⚠️
frac/sealed/lids/iterator_desc.go 91.48% 2 Missing and 2 partials ⚠️
cmd/seq-db/seq-db.go 0.00% 1 Missing ⚠️
frac/sealed/lids/loader.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             336-compaction     #445   +/-   ##
=================================================
  Coverage                  ?   70.61%           
=================================================
  Files                     ?      234           
  Lines                     ?    18556           
  Branches                  ?        0           
=================================================
  Hits                      ?    13104           
  Misses                    ?     4476           
  Partials                  ?      976           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheb0

cheb0 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@seqbenchbot up 336-compaction mixed

@seqbenchbot

seqbenchbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Nice, @cheb0 <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - e6ff702f.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Block_Pack-4 9b461f fecc13
113401.00 B/op 375553.00 B/op 3.31 🔴
98099.00 ns/op 140391.00 ns/op 1.43 🔴
MergeSource-4 ------ fecc13
NaN B/op 74651168.00 B/op NaN 🔴
NaN allocs/op 2010805.00 allocs/op NaN 🔴
NaN ns/op 1558343097.00 ns/op NaN 🔴
MutexListAppend-4 9b461f fecc13
206.62 MB/s 184.72 MB/s 0.89 🔴
77569546.00 ns/op 86619310.00 ns/op 1.12 🔴
Sealing_NoSort-4 9b461f fecc13
23887816.00 B/op 443655488.00 B/op 18.57 🔴
1093073389.00 ns/op 1340519310.00 ns/op 1.23 🔴
Sealing_WithSort-4 9b461f fecc13
41360712.00 B/op 459027448.00 B/op 11.10 🔴

@cheb0

cheb0 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@seqbenchbot down e6ff702f

@seqbenchbot

seqbenchbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Nice, @cheb0 <(-^,^-)=b!

The benchmark with identificator e6ff702f was finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
base comp diff base comp diff base comp diff base comp diff base comp diff base comp diff
bulk
warm 77.46 77.97 +0.67% 35.02 33.15 -5.36% 68.00 69.00 +1.47% 140.00 141.00 +0.71% 205.00 197.00 -3.90% 26939.00 26964.00 +0.09%
service:payment-backend-eu
AND k8s_namespace:prod
AND level:[0 to 3]
AND (
    message:'failed'
    OR message:'timeout'
)
warm 79.96 81.66 +2.14% 30.66 32.61 +6.37% 69.00 72.00 +4.35% 143.00 147.00 +2.80% 189.00 191.00 +1.06% 4875.00 4622.00 -5.19%

Have a great time!

@cheb0 cheb0 changed the title feat: roaring bitmaps in posing lists feat: add roaring bitmaps in posing lists Jun 24, 2026
@cheb0 cheb0 marked this pull request as ready for review June 24, 2026 05:59
@cheb0 cheb0 force-pushed the 329-lid-bitmaps branch from 9fdf358 to 8b6ca3a Compare June 24, 2026 06:00
@cheb0 cheb0 marked this pull request as draft June 24, 2026 06:10
@cheb0 cheb0 marked this pull request as ready for review June 24, 2026 06:10
@cheb0 cheb0 closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants