fix(tests): eight spec_checklist targets read repo paths from the crate dir — 77 vacuous rows now read the tree (#3130) - #3131
Closed
noahgift wants to merge 1 commit into
Closed
Conversation
…te dir -- 77 vacuous rows now read the tree (#3130) Defect: integration tests under crates/aprender-core/tests/ bind repo-relative paths as bare string literals but cargo/nextest run a test binary with cwd = the CRATE dir, so the file is never found; most rows hid it behind if let Ok and were vacuous. Anchor: Added workspace_root() helper to resolve paths correctly from the crate directory to the repo root. Summary Lines: - spec_checklist_f_wasm: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s - spec_checklist_q_qwen_coder: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 118.50s - spec_checklist_r_model_import: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s - spec_checklist_t_realizar: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s - spec_checklist_u_performance: ok. 15 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s - spec_checklist_v_sovereign: ok. 15 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s - spec_checklist_w_advanced_perf: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s - spec_checklist_x_anti_stub: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Pmat-Ticket: PMAT-1098 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
noahgift
added
bug
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
added a commit
that referenced
this pull request
Sep 11, 2026
…ery aprender-core integration target, so all eight checklist files must be anchored on this train
Contributor
Author
This was referenced Sep 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3130 (the eight-file sweep; the four targets that already failed are on #3112/#3127/#3128).
Eight
spec_checklist_*integration targets bound repo paths as bare string literals (let spec_path = "docs/specifications/archive/…",let import_cmd = "crates/apr-cli/src/commands/import.rs") and read them from the test binary's cwd — the CRATE dir — so 77 rows guarded byif let Ok(content) = read_to_string(path)passed by never reading the file. Every site now anchors onworkspace_root()(CARGO_MANIFEST_DIR/../.., themonorepo_invariants.rspattern) and every read has a panic message that prints the path tried. No assertion was weakened; no roadmap change, so this stays mergeable behind the 0.67 train (#3127).Written by an agy goal lane (PMAT-1098 phase 4); re-verified by the orchestrator on the lane's commit:
Auto-merge is deliberately NOT armed yet: this branch is off main @ bbd3243 without the #3112 aarch64 lint fix, and gx10 pools carry
clean-roomnow. It is update-branch'd and armed once #3127 lands.🤖 Generated with Claude Code