Skip to content

feat: add timeouts - #1367

Open
sgaist wants to merge 6 commits into
paketo-buildpacks:mainfrom
idiap:feat/add-timeouts
Open

sgaist wants to merge 6 commits into
paketo-buildpacks:mainfrom
idiap:feat/add-timeouts

Conversation

@sgaist

@sgaist sgaist commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Add timeouts to all workflows

This is an initial proposition to open the discussion. I don't claim these values to be the best so feel free to suggest others.

Use Cases

Avoid burning resources if something goes wrong and get quicker feedback.

As an example, on this day (20.08.2026), the lint workflow has had issues several times for the Python buildpacks and rather than fail quickly (it is supposed to have a timeout of 3 minutes), it ran anywhere from 10 minutes to more than an hour for no clear reasons.

While having timeouts will not fix the underlying issue, it will avoid burning runner resources.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sgaist
sgaist requested review from a team as code owners August 20, 2026 19:33
@anthonydahanne

Copy link
Copy Markdown
Member

hello @sgaist !
still want this PR?
Can you please rebase it to resolve conflicts?
Thanks

@sgaist

sgaist commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

@anthonydahanne Yes, I still think it's valuable.

I've updated the PR as requested.

@anthonydahanne anthonydahanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go @sgaist !

@pacostas

Copy link
Copy Markdown
Member

FWIW, this PR touches all the workflows of all implementations across all paketo buildpacks and there might be issues in that case

@sgaist

sgaist commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@anthonydahanne Thanks

@pacostas I agree. That is why I noted in the PR description that I think these value should be good however some more pair of eyes would be appreciated. I tried to get them by looking at several runs on different buildpacks but I may have missing something.

@dmikusa dmikusa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just post something on Slack when this merges so everyone is aware. I suspect it’ll be obvious if something is hitting a timeout but the announcement should help make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants