Conversation
kdeldycke
marked this pull request as draft
September 24, 2026 15:09
kdeldycke
force-pushed
the
windows-command-line-split
branch
from
September 24, 2026 15:23
8d17dc0 to
d2a4dc2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I implemented #3777 a couple of weeks ago, I was annoyed by Windows behavior. And wondered why
shlex.splitis only available on Unix-like platforms. Then while cleaning ancient Python 2 stuff in https://github.com/pallets/click/pull/3817/changes#diff-3bd2075eb8cab59a601f5a021078e5763eea117ae315b04d8d2d719de1f45a97R48 , I discoveredCommandLineToArgvW.This is an attempt to rely on
CommandLineToArgvW, which seems to do the trick, as a Windows equivalent toshlex.split.But digging deeper I stumbled upon the discussion upstream at python/cpython#44990 (comment) , which explain why it was not considered for inclusion in the Python stdlib:
And that explain why this PRs has limits, and why I choose to keep the shell completion relying on
shlex.I propose this PR anyway as it seems to bring the behavior more in line with Windows default, but kept as draft as I need a bit of feedback about this attempt.
Tests
I collected test cases from past discussions to build up a more comprehensive suite: