fix: URL encoding of file location returned by createFile

[AdrianCurtin]

Issue

Closes: #461

createFile() builds the Location it returns by interpolating params.Key straight into a URL. The key is raw, so a filename containing a space or other URL-sensitive character produces a technically malformed URL:

• Before: https://bucket.s3.region.amazonaws.com/test/my file (1).txt
• After: https://bucket.s3.region.amazonaws.com/test/my%20file%20(1).txt

Approach

Encode each path segment of the key when building the URL, the same way getFileLocation() already does, so separators stay separators:

const location = `${endpoint}/${params.Key.split('/').map(encodeURIComponent).join('/')}`;

The key handed to S3 is untouched and stays raw, which is what the SDK expects. Only the returned URL changes.

Both return paths are covered. createFile resolves Location in two places, the streaming Upload path and the buffer PutObjectCommand path, and both had the bug.

Tests

spec/test.spec.js gains a case per return path, using my file (1).txt from the issue. Both assert the encoded form is present, the raw form is absent, and that the bucketPrefix separator is not encoded to %2F. Both fail against the previous Location and pass here.

Full suite passes.

Related pull requests

These all touch createFile or getFileLocation in index.js. Merging them in this order leaves the fewest conflicts, verified by trial merges of all six together, which pass the suite once resolved:

#336 → #594 → #597 → #591 → #593 → #242

• fix: Prevent double-encoded presigned urls from s3 #336 presigned urls used a pre-encoded key
• fix: Bucket region is ignored, breaking access to buckets in opt-in regions #594 bucket region missing from the direct access url
• feat: Support asynchronous generateKey and validate the generated key #597 asynchronous generateKey
• fix: URL encoding of file location returned by createFile #591 percent-encoding of the Location url
• fix: File location returned by createFile omits the bucket when a custom endpoint is configured #593 Location omitted the bucket for custom endpoints
• feat: Revise createFile logic to return modified filenames and location #242 createFile reporting the stored name and url

#336 and #594 conflict with nothing. The rest collide on the createFile prologue and on the same anchor in spec/test.spec.js, where the conflict truncates each side's block, so the incoming describe has to be re-inserted whole rather than resolved line by line.

Conflict warning. The conflicting region includes const params = await this._buildCreateFileParams(...) from #597. Resolving in favor of the location work drops the await, which leaves a Promise where the params object is expected and fails every upload with TypeError: Cannot read properties of undefined (reading 'split'). Keep the await. Landing #597 first avoids the conflict entirely.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

Warning

Review limit reached

@AdrianCurtin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b5360b21-cfcd-4afa-8913-d72f5d008737

📥 Commits

Reviewing files that changed from the base of the PR and between b9245cb and 76fa212.

📒 Files selected for processing (2)

• index.js
• spec/test.spec.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}