Skip to content

fix: honor HasConversion when a property has a HasQueryName alias #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdevito3 merged 1 commit into from
Sep 29, 2026
Merged

fix: honor HasConversion when a property has a HasQueryName alias #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 204 additions & 0 deletions QueryKit.IntegrationTests/Tests/HasConversionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,208 @@ public async Task can_filter_by_email_with_has_conversion()
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_email_with_query_name_and_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var testEmail = $"{Guid.NewGuid()}@example.com";
var person = new FakeTestingPersonBuilder()
.WithEmail(testEmail)
.Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""mail == "{testEmail}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Email).HasQueryName("mail").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_email_property_path_when_query_name_and_has_conversion_are_configured()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var testEmail = $"{Guid.NewGuid()}@example.com";
var person = new FakeTestingPersonBuilder()
.WithEmail(testEmail)
.Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""Email == "{testEmail}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Email).HasQueryName("mail").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_email_value_with_query_name_and_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var testEmail = $"{Guid.NewGuid()}@example.com";
var person = new FakeTestingPersonBuilder()
.WithEmail(testEmail)
.Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""Email.Value == "{testEmail}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Email).HasQueryName("mail").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_null_email_with_query_name_and_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var title = Guid.NewGuid().ToString();
var person = new FakeTestingPersonBuilder()
.WithTitle(title)
.Build();
person.Email = null!;
var personTwo = new FakeTestingPersonBuilder()
.WithTitle(title)
.Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = """mail == null""";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Email).HasQueryName("mail").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People
.Where(x => x.Title == title);
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_nested_postal_code_with_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var postalCode = Guid.NewGuid().ToString("N")[..10];
var person = new FakeTestingPersonBuilder()
.WithPhysicalAddress(new Address("Line1", "Line2", "City", "State", postalCode, "Country"))
.Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""PhysicalAddress.PostalCode == "{postalCode}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.PhysicalAddress.PostalCode).HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_by_nested_postal_code_with_query_name_and_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var postalCode = Guid.NewGuid().ToString("N")[..10];
var person = new FakeTestingPersonBuilder()
.WithPhysicalAddress(new Address("Line1", "Line2", "City", "State", postalCode, "Country"))
.Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""zip == "{postalCode}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.PhysicalAddress.PostalCode).HasQueryName("zip").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}

[Fact]
public async Task can_filter_guid_with_contains_query_name_and_has_conversion()
{
// Arrange
var testingServiceScope = new TestingServiceScope();
var person = new FakeTestingPersonBuilder().Build();
var personTwo = new FakeTestingPersonBuilder().Build();

await testingServiceScope.InsertAsync(person, personTwo);

var input = $"""identifier @= "{person.Id.ToString()[..13]}" """;
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Id).HasQueryName("identifier").HasConversion<string>();
});

// Act
var queryablePeople = testingServiceScope.DbContext().People;
var appliedQueryable = queryablePeople.ApplyQueryKitFilter(input, config);
var people = await appliedQueryable.ToListAsync();

// Assert
people.Count.Should().Be(1);
people[0].Id.Should().Be(person.Id);
}
}
Loading
Loading