Skip to content

fix(filter): resolve every property reference with one resolver #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdevito3 merged 14 commits into from
Sep 29, 2026
Merged

fix(filter): resolve every property reference with one resolver #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d4e2cb3
test(filter): use fixed or unique data in tests that failed at random
pdevito3 Sep 29, 2026
89d17cb
refactor(filter): resolve filter property references in one place
pdevito3 Sep 29, 2026
91debe7
fix(filter): remove unknown and prevented clauses instead of using true
pdevito3 Sep 29, 2026
797ff0f
fix(filter): check permission and depth for properties in arithmetic
pdevito3 Sep 29, 2026
6140275
fix(filter): check permission for a property on the right side
pdevito3 Sep 29, 2026
5008c93
fix(filter): look up property settings by the resolved member path
pdevito3 Sep 29, 2026
d5f27a0
fix(sort): look up the sort permission by the resolved member path
pdevito3 Sep 29, 2026
3b05ab4
fix(filter): apply prevent settings to derived properties and custom …
pdevito3 Sep 29, 2026
9f3b973
fix(filter): resolve query names in property lists and arithmetic
pdevito3 Sep 29, 2026
459544e
fix(filter): keep a query name in a nested path in alias replacement
pdevito3 Sep 29, 2026
ff9b5c3
fix(filter): accept a nested property path on the right side
pdevito3 Sep 29, 2026
64f7487
fix(config): apply a property max depth only to its own path
pdevito3 Sep 29, 2026
50a1631
fix(filter): treat an unknown property in arithmetic as an unknown pr…
pdevito3 Sep 29, 2026
b21b41a
fix(filter): remove a prevented clause that uses its query name
pdevito3 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion QueryKit.IntegrationTests/Tests/DatabaseFilteringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ public async Task can_filter_by_string_for_nested_collection()
var testingServiceScope = new TestingServiceScope();
var faker = new Faker();
var preparationOne = new FakeIngredientPreparation().Generate();
preparationOne.Text = Guid.NewGuid().ToString();
var preparationTwo = new FakeIngredientPreparation().Generate();
var fakeIngredientOne = new FakeIngredientBuilder()
.WithPreparation(preparationOne)
Expand Down Expand Up @@ -435,6 +436,7 @@ public async Task can_filter_by_string_for_nested_collection_with_alias()
var testingServiceScope = new TestingServiceScope();
var faker = new Faker();
var preparationOne = new FakeIngredientPreparation().Generate();
preparationOne.Text = Guid.NewGuid().ToString();
var preparationTwo = new FakeIngredientPreparation().Generate();
var fakeIngredientOne = new FakeIngredientBuilder()
.WithPreparation(preparationOne)
Expand Down Expand Up @@ -885,7 +887,7 @@ public async Task can_filter_nested_property_using_ownsone()
.WithPhysicalAddress(new Address(faker.Address.StreetAddress()
, faker.Address.SecondaryAddress()
, faker.Address.City()
, faker.Address.State()
, Guid.NewGuid().ToString()
, faker.Address.ZipCode()
, faker.Address.Country()))
.Build();
Expand Down
Loading
Loading