Skip to content

chore(operators)!: remove ArithmeticOperator.FromSymbol #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdevito3 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −28
Open

chore(operators)!: remove ArithmeticOperator.FromSymbol #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions QueryKit.UnitTests/ArithmeticOperatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,9 @@ namespace QueryKit.UnitTests;

public class ArithmeticOperatorTests
{
[Theory]
[InlineData("+", "+")]
[InlineData("-", "-")]
[InlineData("*", "*")]
[InlineData("/", "/")]
[InlineData("%", "%")]
public void from_symbol_returns_the_operator_for_the_symbol(string symbol, string expectedSymbol)
{
var op = ArithmeticOperator.FromSymbol(symbol);

op.Should().NotBeNull();
op!.Symbol.Should().Be(expectedSymbol);
}

[Fact]
public void from_symbol_returns_null_for_an_unknown_symbol()
public void from_symbol_is_not_part_of_the_public_api()
{
var op = ArithmeticOperator.FromSymbol("^");

op.Should().BeNull();
typeof(ArithmeticOperator).GetMethod("FromSymbol").Should().BeNull();
}
}
10 changes: 0 additions & 10 deletions QueryKit/Operators/ArithmeticOperator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,6 @@ protected ArithmeticOperator(string symbol, int precedence)
public static ArithmeticOperator Multiply => new MultiplyOperator();
public static ArithmeticOperator Divide => new DivideOperator();
public static ArithmeticOperator Modulo => new ModuloOperator();

public static ArithmeticOperator? FromSymbol(string symbol) => symbol switch
{
"+" => Add,
"-" => Subtract,
"*" => Multiply,
"/" => Divide,
"%" => Modulo,
_ => null
};
}

internal class AddOperator : ArithmeticOperator
Expand Down
Loading