fix(exceptions): stop leaking internal type names in ParsingException - #128
Merged
Merged
Conversation
ParsingException used to append the wrapped exception's raw Message, which could include .NET type names and Sprache parser internals. It now shows only the line and column from a parse failure, and keeps the original exception as InnerException for full server-side detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParsingExceptionused to append the wrapped exception's rawMessagetext, which could include .NET type names and Sprache parser internals visible to an API client that shows the message.InnerExceptionfor full server-side detail.Test plan
dotnet test QueryKit.UnitTestspasses (386 tests)System.,Sprache., or type-name text for a bad operator, a bad logical operator, and a value the parser rejectsverify-querykitharness, against both an in-memoryIEnumerabletarget and a real PostgresIQueryabletarget