Skip to content

fix(filter)!: use a constant for a TimeOnly value on net6.0 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdevito3 merged 1 commit into from
Oct 2, 2026
Merged

fix(filter)!: use a constant for a TimeOnly value on net6.0 #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions QueryKit/FilterValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,15 @@ private static Expression Literal(object? value, Type type)
: Expression.New(type.GetConstructor(new[] { underlying })!, created);
}

// The TimeOnly constructor with microseconds needs .NET 7. On net6.0, Expression.New throws
// ArgumentNullException, the same as v1.14.2.
private static Expression NewTimeOnly(TimeOnly time)
// The TimeOnly constructor with microseconds needs .NET 7. Without it, the value is a constant.
private static Expression? NewTimeOnly(TimeOnly time)
{
var ctor = typeof(TimeOnly).GetConstructor(new[] { typeof(int), typeof(int), typeof(int), typeof(int), typeof(int) })!;
var ctor = typeof(TimeOnly).GetConstructor(new[] { typeof(int), typeof(int), typeof(int), typeof(int), typeof(int) });
if (ctor == null)
{
return null;
}

var fractionalTicks = time.Ticks % TimeSpan.TicksPerSecond;
var millisecond = (int)(fractionalTicks / TimeSpan.TicksPerMillisecond);
var microsecond = (int)(fractionalTicks % TimeSpan.TicksPerMillisecond / 10);
Expand Down
Loading