Conversation
This was referenced Oct 1, 2026
A quoted time dropped a fraction with fewer than 3 digits, so Time == "08:30:00.5" compared with 08:30:00. Keep every fraction digit of a quoted time, like an unquoted time. The rightIsQuotedLiteral argument of CreateRightExpr is removed, because the time conversion was its only user. BREAKING CHANGE: a quoted time with a fraction of 1 or 2 digits now keeps the fraction. Time == "08:30:00.5" now matches 08:30:00.500, not 08:30:00. Remove the fraction to match the whole second.
pdevito3
force-pushed
the
fm/qk-breaking-short-time-fraction
branch
from
October 1, 2026 21:42
58c8607 to
f6385c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For later consideration in a major version. Do not merge now. This PR is one of two PRs that replace #144. Each PR has one breaking change. The captain decides on each PR separately.
#134 restored the v1.14.2 rule (restore commit
b49ad2b). This PR re-applies this part of5c84ef6.What breaks
A quoted time with a fraction of 1 or 2 digits keeps the fraction. On v1.14.2 and main, a quoted time uses the milliseconds only when the fraction has 3 or more digits, and the microseconds only when it has 6 or more. An unquoted time already keeps every digit on main.
Example
Time == "08:30:00.5"Time == "08:30:00.50"Time == "08:30:00.500"Justification
.5is half a second. A filter that drops it gives wrong rows without an error. A quoted time and an unquoted time now give the same value.Migration
If you wrote a short fraction and expected the whole second, remove the fraction.
Code
The
rightIsQuotedLiteralargument ofCreateRightExprandCreateRightExprFromTypeis removed. The time conversion was its only user.README
The date and time format list says that a time fraction keeps every digit.
Tests
FilterParsingRegressionTests.fractional_seconds_are_kept: the casesTime == "08:30:00.5"andTime == "08:30:00.50"expect the fraction again.quoted_time_with_fewer_than_three_fraction_digits_drops_the_fractionis removed. It held the v1.14.2 behavior.FilterParsingRegressionTests.fractional_second_value_matches_by_its_fraction: a quoted.5matches the fraction row on Postgres.dotnet teston this branch: 470 unit tests and 297 Postgres integration tests (Testcontainers) pass, 0 failures.Rebase on main
This branch is rebased on current main. Main #169 added a call to
CreateRightExprFromTypein the conversion path. This PR removes therightIsQuotedLiteralargument from that call too. TheIsQuotedLiteralflag stays in the parse result, because the property path check on the right side uses it.