You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it's good to merge, the concept that the parent names at the same layer as the feature can be used for deduplication is logical and unlikely to cause error.
The issue description was missing the concrete example which was included in the tests:
Given the feature geonames:region:2950157 ("Land Berlin", en: "State of Berlin") along with another feature at the same level whosonfirst:region:85682499 ("Berlin") in the results.
We can use the parent.region = ["Berlin"] property of geonames:region:2950157 to establish that it is equivalent to whosonfirst:region:85682499
The parent.region_id = [85682499] property of geonames:region:2950157 further indicates that the two are duplicate, so we could consider only using the IDs, I'm open to both methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the parent hierarchy contains tokens which are relevant for deduplication.
For example if we have a
geonamesrecord onlayer=localitywith thename.default="Land Berlin"and alsoparent.locality=["Berlin"].In this case we can use the parent field provided by the PIP service to assist in the deduplication process.