Unify on using pretty diff and Javascript fixtures - #1721
Merged
Conversation
These fixtures have been a considerable source of pain and annoyance when working with query code. This is a first step at some quality of life improvements. Some fixtures were written as JSON, which seems like the right call (Elasticsearch queries are JSON), but in practice means we can't have comments, etc, and different fixtures have different syntax. Most are Javascript, and after this commit all of them are. We also use difflet for better visual diffs, which has been available for a while in this repo but never really used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixtures have been a considerable source of pain and annoyance when working with query code. This is a first step at some quality of life improvements.
Some fixtures were written as JSON, which seems like the right call (Elasticsearch queries are JSON), but in practice means we can't have comments, etc, and different fixtures have different syntax. Most are Javascript, and after this commit all of them are.
We also use difflet for better visual diffs, which has been available for a while in this repo but never really used.