Skip to content

feat: Add excluding for categories - #143 - #1725

Open
arnesetzer wants to merge 2 commits into
pelias:masterfrom
arnesetzer:feat/categories-exclude
Open

feat: Add excluding for categories - #143#1725
arnesetzer wants to merge 2 commits into
pelias:masterfrom
arnesetzer:feat/categories-exclude

Conversation

@arnesetzer

Copy link
Copy Markdown
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

This is the second of two PRs who needs to be merged together. The first one is here: pelias/query#143


Here's the reason for this change 🚀

For a project I need the functionality to exclude categories like layers which is currently not possible. Maybe it is a useful thing to have on upstream.


Here's what actually got changed 👏

  • query/{search,autocomplete,reverse,text_parser_pelias}.js: Add support for the 'input:not_categories'
  • sanitizer/_categories.js: Parsing the excluding categories and clean it
  • test/unit/sanitizer/_categories.js: test

Here's how others can test the changes 👀

@Joxit Joxit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for using pelias and submitting PR 😄
I will let the team decide but LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants