fix: switch to b64veryfast:decode64_url/1#985
Open
charmful0x wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
about
discovered this while trying to use
rebar3 device publish-- debugged more and found that signed ans104 are failing the item_verify check. this led to b64veryfast URL decode usage inhb_util:decode/1.the unchecked decoder dont preserve roundtrip correctness for larger unpadded values such as RSA owners/signatures which breaks ans104 commitment verificationrepro
anything that does hb_util:decode/1 is broken on edge, for example dev_ans104.erl
rebar3 device test --module dev_ans104
on this branch fix it is back to 100% success