Skip to content

fix: switch to b64veryfast:decode64_url/1#985

Open
charmful0x wants to merge 1 commit into
edgefrom
fix/b64veryfast-decode
Open

fix: switch to b64veryfast:decode64_url/1#985
charmful0x wants to merge 1 commit into
edgefrom
fix/b64veryfast-decode

Conversation

@charmful0x

Copy link
Copy Markdown

about

discovered this while trying to use rebar3 device publish -- debugged more and found that signed ans104 are failing the item_verify check. this led to b64veryfast URL decode usage in hb_util:decode/1. the unchecked decoder dont preserve roundtrip correctness for larger unpadded values such as RSA owners/signatures which breaks ans104 commitment verification

repro

anything that does hb_util:decode/1 is broken on edge, for example dev_ans104.erl
rebar3 device test --module dev_ans104

=======================================================
  Failed: 14.  Skipped: 0.  Passed: 10.
===> device test failed: eunit_failed

on this branch fix it is back to 100% success

=======================================================
  All 24 tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant