fix(client): preserve underscores in SQL column aliases#3193
Closed
LarryHu0217 wants to merge 1 commit into
Closed
fix(client): preserve underscores in SQL column aliases#3193LarryHu0217 wants to merge 1 commit into
LarryHu0217 wants to merge 1 commit into
Conversation
Signed-off-by: Liang Hu <lh3057@columbia.edu>
Member
|
I've update #3187 to clarify this is an explicit design decision, not a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves underscores in column aliases generated by
GenericSQLVirtualServerModel. The SQL builder previously replaced_with-, so selectingaccount_numberproduced an alias namedaccount-numberand changed the schema exposed to clients.The fix keeps the original identifier while continuing to escape embedded double quotes. Regression tests cover both flat and aggregated view queries.
Fixes #3187.
Validation
cargo test --features generate-proto,omit_metadata generic_sql_model --no-default-features(25 passing)rustfmt --checkon the changed Rust filesgit diff --check origin/master...HEADTooling assistance
Codex assisted with implementation and local validation. I reviewed the resulting diff and test output.