Daily tech-debt sweep — 2026-09-22 - #1789
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PR Surface ReportCompared Summary: 81 changed file(s) | EF migrations: 0 added file(s), max 0/1 per context Reforge Surface Score
Section Deltas
Section Size & Complexity Deltas
Rule Deltas
Corpus Size & Complexity
At head: largest class Published Write Surface14 of 48 sections publish write capability, 23 interfaces (0). Interface SurfaceNo new interfaces or interface methods. Diff Size
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Reviewed commit 0634102. 1 inline finding(s) posted. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0634102131
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve ShiftsResource append conflicts: keep main's rota-email keys and the branch's ShiftProfile_* keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jUyNBoz1pjgWZmmTPryHr
Reverted: a4977e5 Move Google resource sort to service — bulk read lost ProvisionedAt order that group sync's First() relies on Reverted: c21664c CONT-2 localize container errors — CityPlanningController still shows ex.Message, now a raw key Repaired: 60d7c44 rideshare notifications — render inside CultureScope so dates follow recipient; drop orphaned MineLabel Repaired: 25e57db, 566313e EventSubmission_* -> Events_Submission_* Repaired: 9ecf0a4 AdminEditTeam_* (new keys) -> Teams_EditTeam_* Repaired: 59c6bda, 0961c35, 6acbf49 new Profile_*/Guest_* -> Users_Profile_*/Users_Guest_* Repaired: 839c074 ShiftProfile_* -> Shifts_ShiftProfile_* Repaired: 03623fb new TicketTransfer_* -> Tickets_TicketTransfer_* Fixed: RideshareService.cs:673 recipient culture never applied (Claude) Fixed: RideshareService.cs:276 notification dates in actor culture (Codex) Fixed: RideshareService.cs:677 orphaned MineLabel (Codex) Fixed: TeamResourceService.cs:37 bulk read unordered (Codex, via revert) Fixed: EventsResource.resx:91 new keys lack section prefix (Codex) Review-round: 1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jUyNBoz1pjgWZmmTPryHr
Owner
Author
Debt reviewOf 26 commits: 16 good, 8 repaired, 2 reverted. Main was merged in with a separate commit ( Commit verdicts
Findings triage (round 1 · bar: P0/P1/in-scope P2)
Issues filed
Rounds spent: 1 of 3 · pushed Recommendation: merge after steward rounds. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5cd1bd0d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reverted: 010e513 Move campaign tracking sort out of repository — sort landed in CampaignService, still below the controller boundary Reverted: 524f56c Move camp role definition sorting out of repository — sort landed in CampRoleService, same relocation Both repository sorts and their DisplaySortInControllers baseline lines are restored, so the debt stays recorded. Fixed: CampaignService.cs:577 display sort moved into service (Codex, via revert) Fixed: CampRoleService.cs:662 display sort moved into service (Codex, via revert) Review-round: 2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jUyNBoz1pjgWZmmTPryHr
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56e26bf8f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The submit forms' <label asp-for> labels still render English [Display(Name = ...)] literals. SharedResource has no matching keys, so the row was removed too early. It now covers only those labels. Fixed: Events/Docs/debt.yml:30 EVENTS-7 removed while labels unlocalized (Codex) Review budget is spent: this was the last round commit (ceiling 3). Review-round: 3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jUyNBoz1pjgWZmmTPryHr
peterdrier
pushed a commit
that referenced
this pull request
Sep 22, 2026
…dy fixed Textual conflict was only Email/Docs/debt.yml — both sides closed EMAIL-2, this side then added EMAIL-3..7. Kept ours; next_id only ever increases. The larger conflict was semantic. Main's nightly sweep (#1789) independently fixed the subject double-encoding this run had re-filed, so ISSUES-9, SHIFTS-5 and GOOGLE-3 are deleted unworked: verified on the merged tree that every subject argument at those sites now passes raw while the body arguments stay encoded. The finding was real when filed; the row would have been stale on arrival. next_id preserved in all three ledgers. CENTRAL-65 checked against the same sweep and left standing — all three architecture test files still reference the rule it names. Run file records the deletions and Peter's rulings on the three Needs-Peter items (close / retarget / leave it). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SCrRPogs7ZYUv9VwxewFZ3
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily debt sweep
Completed 25 substantive fixes in 90m 9s. Working tree is clean; all commits are local for wrapper publication.
9b3955e94EMAIL-2 — fixed encoded email subjects. Tests: Issues 139, Shifts 627, Google 312.37f0d5b49TICKETS-3 — removed duplicate ticket cache resolver. Tests: Tickets 207.124a89f99MLITE-1 — removed unused MailerLite date converter. Tests: MailerLite 121.2f7bd0769— moved camp role-slot ordering to its consumer. Tests: Camps 279, display-sort baseline.246012750SHIFTS-1/2 — consolidated signup helpers. Tests: Shifts 627.c21664c3eCONT-2 — localized container validation errors. Tests: Containers 41, resource parity 32.010e513b5— moved campaign tracking sort to service. Tests: Campaigns 55, baseline.a4977e5a9— moved Google resource sort to service. Tests: Google 312, baseline.9ecf0a4a6TEAMS-3 — localized team edit UI. Tests: Teams 269, parity.25e57db1c/566313ed6EVENTS-7 — localized individual, barrio, and card event surfaces. Tests: Events 185, parity.eeea18d34CENTRAL-14 — persisted explicit zero shift offsets. Tests: Shifts 627.524f56c2f— moved camp role-definition sort to service. Tests: Camps 279, baseline.60d7c4401CENTRAL-41 partial — localized rideshare notifications. Tests: Rideshare 105, parity.1f70242a5CENTRAL-60 — constrained Codex command output. Static command/YAML checks passed.59c6bdae8— localized profile communication feedback. Tests: Users 648, parity.0961c3569— localized email-merge confirmation. Tests: Users 648, parity.6acbf4960— localized guest-account deletion and communication feedback. Tests: Users 648, parity.839c07473— localized shift-profile failures. Tests: Shifts 627, parity.03623fbf4— localized ticket-transfer feedback. Tests: Tickets 207, parity.1a1e0b719— localized event state-gate feedback. Tests: Events 185, parity.e6d6ab8a5— localized event submission feedback. Tests: Events 185, parity.9a0ed28d7— localized event-upload validation. Tests: Events 185, parity.e67328754— localized event-upload completion. Tests: Events 185, parity.063410213— localized guest data-export failure. Tests: Gdpr 18.d10c53914corrected an unused local introduced during the Shift helper change; it is excluded from the substantive count.Hygiene: updated related ledger rows only alongside completed production/tooling fixes; no docs-only hygiene commit was counted.
Skipped safely:
The wrapper should run the final full build and non-integration suite before publishing.
Goal time: 90m; actual worker time: 90m 52s; total run through validation: 94m 36s.
Runner validation: build and tests passed; Humans.Integration.Tests excluded.