Finance year page: readable figure strips, Holded docs behind the actual - #1791
Conversation
The category/group figures sat inside the accordion's <h2>, so the display serif leaked into them and <small> shrank them to ~13px. They now render in the body face at 0.95rem with tabular numerals and a quiet uppercase label; Holded's value moves off Bootstrap's text-info blue onto the palette's gold. Expanding a category now also lists the approved Holded purchase docs its actual sums (number linking to Holded, supplier, date, amount), so a figure that looks wrong can be traced to the document that caused it. GetActualsForYearAsync carries those docs on HoldedActualRow rather than gaining a second contract method — the service already had them in hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WSSBeC1Xg1X31oqgeWGdsw
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed commit 4f2861e — no issues found. |
PR Surface ReportCompared Summary: 9 changed file(s) | EF migrations: 0 added file(s), max 0/1 per context Reforge Surface Score
Section Deltas
Section Size & Complexity Deltas
Rule Deltas
Corpus Size & Complexity
At head: largest class Published Write Surface14 of 48 sections publish write capability, 23 interfaces (0). Interface SurfaceNo new interfaces or interface methods. Diff Size
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f2861ef7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No Budget view names a Humans.Finance.Contracts type: YearDetail reaches HoldedActualRow through `var holded = ...GetValueOrDefault(cat.Id)`, so the import only added an orphan using to every generated Budget view (code-review-rules.md:107). Codex's other two findings declined in-thread: the zero-net-actual case needs offsetting signed totals Finance never ingests, and the figure strip's text-nowrap predates this diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SR1xAMAXmCep675JvCSnoh Review-round: 1
2 participants
What
Two changes on
/Finance(the budget year page):Planned spend · Actual · Remaining · Holded) sat inside the accordion's<h2>, so the display serif (Cormorant Garamond) leaked into them and.smallshrank them to ~13px. They now render in the body face at 0.95rem, tabular numerals, with the label as a quiet uppercase caption and a hairline divider between figures. Holded's value moves off Bootstrap'stext-infoblue onto the palette's gold — "from the books", not "info".Why
Peter: the figures are too small and in a weird font, the Holded blue is bad, and the Holded number needs its constituent lines visible for diagnosis.
Existing surface checked
No new contract method.
GetActualsForYearAsyncalready loaded the docs it sums, soHoldedActualRowgained aDocslist rather thanIHoldedFinanceServiceReadgaining a second method;BudgetAdminControlleris its only caller. The Holded doc URL was already built inline inGetUnmatchedAsync— it is now a privateHoldedDocUrlhelper used by both. Styling reuses the existing--h-font-body/--h-gold-dark/--h-sepiatokens insite.css.UI changes / screenshots
No preview run from here — the change is visible on the PR's preview deploy.
Checklist
mainonpeterdrier/Humans(the QA fork).origin/main.EF migrations— no schema change.NuGet packages updated?— none.New project rule?— none surfaced.dotnet build Humans.slnx -v quiet: 0 errors (13 pre-existing warnings);dotnet test Humans.slnx -v quiet: all green.memory/code/localization-admin-exempt.md).Reviewer notes
The surface list touches three files but is one change:
HoldedActualRowgainsDocs, the Budget view model carries the row instead of the bare decimal, and the view renders it. Docs updated inFinance.mdandBudget.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01WSSBeC1Xg1X31oqgeWGdsw
Generated by Claude Code