Google Accounts: link the two-step guide in Reset + 2FA copy text - #1794
Conversation
The one-shot recovery credentials for Reset + 2FA now end with a short blurb and an absolute link to /Guide/TwoStepVerification, so the admin can paste one message instead of writing the setup instructions by hand each time. Password-only resets are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018grYTQkKyEGXcPLxqQKnwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed commit b9854b6 — no issues found. |
PR Surface ReportCompared Summary: 2 changed file(s) | EF migrations: 0 added file(s), max 0/1 per context Reforge Surface Score
Section DeltasNo section score changes. Section Size & Complexity DeltasNo section size/complexity changes. Rule DeltasNo rule score changes. Published Write Surface14 of 48 sections publish write capability, 23 interfaces (0). Interface SurfaceNo new interfaces or interface methods. Diff Size
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9854b6469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The combined-recovery acceptance criterion in workspace-account-provisioning.md still specified the exact two-line pw/2fa clipboard payload. Update it to the new payload (credentials, one-time-code blurb, absolute /Guide/TwoStepVerification link) and note the password-only fallback when no backup code came back. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9bnuNRMZfUyxdMcJz2FRQ
A steward whose first subscribe_pr_activity fails and only succeeds on a later retry has a window in which review comments and failed checks were never queued. Nothing polls, so those events were silently lost: the steward just waited for new ones. Seen on #1794. Require one read-only, counts-only check of the PR right after a late subscribe, classified and dispatched like any other wake. The fast path (subscribe succeeds at spawn) is unchanged. Claude-Session: https://claude.ai/code/session_01X9bnuNRMZfUyxdMcJz2FRQ Co-authored-by: Claude <noreply@anthropic.com>
2 participants
What
The one-shot recovery credentials shown after Reset + 2FA on
/Google/Accountsnow end with a short blurb and an absolute link to/Guide/TwoStepVerification, so the copy-to-clipboard text is a complete message to paste to the human. Password-only resets are unchanged.Why
Peter does this reset often and was writing the "now set up 2FA properly" instructions by hand each time.
Existing surface checked
No new durable surface. The URL is built with
Url.Actionin the view, matching the absolute-link pattern used in the Events and Store controllers. The guide page isAllowAnonymous, so the link works for a locked-out human.UI changes / screenshots
Clipboard text after Reset + 2FA becomes:
The
<pre>in the modal now wraps so the long line stays readable.Checklist
mainonpeterdrier/Humans(the QA fork). No direct commits tomain.origin/main, notupstream/main.EF migrationsnone.NuGet packages updated?no.New project rule?no.tests/Humans.GoogleIntegration.Tests(311 passed). Admin-only page, so no new localization keys permemory/code/localization-admin-exempt.md.Nav coverageno new page.GuideFiles' existing"TwoStepVerification"entry.Dates/times via NodaTimen/a.Reviewer notes
Wording of the blurb is a first draft; easy to tweak in the view.
🤖 Generated with Claude Code
https://claude.ai/code/session_018grYTQkKyEGXcPLxqQKnwF
Generated by Claude Code