Skip to content

chore: fix flaky license check for dario.cat/mergo #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsivaprasad wants to merge 1 commit into from
Closed

chore: fix flaky license check for dario.cat/mergo #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ licenses:
GOOS=linux $(go-licenses) report ./... \
--ignore github.com/pgEdge/control-plane \
--ignore github.com/eclipse/paho.golang \
--ignore dario.cat/mergo \
--template=NOTICE.txt.tmpl > NOTICE.txt

.PHONY: licenses-ci
Expand Down
3 changes: 1 addition & 2 deletions NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND

```


## dario.cat/mergo

* Name: dario.cat/mergo
Expand Down Expand Up @@ -64,9 +63,9 @@ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

```


## github.com/alessio/shellescape

* Name: github.com/alessio/shellescape
Expand Down
37 changes: 37 additions & 0 deletions NOTICE.txt.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,43 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND

```

## dario.cat/mergo

* Name: dario.cat/mergo
* Version: v1.0.0
* License: [BSD-3-Clause](https://github.com/imdario/mergo/blob/v1.0.0/LICENSE)

```
Copyright (c) 2013 Dario Castañé. All rights reserved.
Copyright (c) 2012 The Go Authors. All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following disclaimer
in the documentation and/or other materials provided with the
distribution.
* Neither the name of Google Inc. nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
```

Comment on lines +31 to +67

@coderabbitai coderabbitai Bot Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify dario.cat/mergo version, license URL, and license text

echo "=== Checking go.mod for dario.cat/mergo version ==="
rg -n "dario.cat/mergo" go.mod

echo -e "\n=== Verifying license URL accessibility ==="
curl -s -o /dev/null -w "HTTP Status: %{http_code}\n" "https://github.com/imdario/mergo/blob/v1.0.0/LICENSE"

echo -e "\n=== Fetching actual license text from repository ==="
curl -s "https://raw.githubusercontent.com/imdario/mergo/v1.0.0/LICENSE"

Repository: pgEdge/control-plane

Length of output: 1805

Adjust dario.cat/mergo NOTICE entry to ensure the license URL resolves cleanly

  • go.mod specifies dario.cat/mergo v1.0.0 (indirect), matching the NOTICE version.
  • The BSD-3-Clause license text for v1.0.0 matches the text included in NOTICE.txt.tmpl (lines 31-67).
  • The provided GitHub license link returns an HTTP 301 (redirect) when fetched; update it to a URL that returns 200 directly (or a non-redirecting equivalent) to avoid compliance/automation issues.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@NOTICE.txt.tmpl` around lines 31 - 67, Update the dario.cat/mergo NOTICE
entry so the license URL does not redirect: replace the current GitHub blob URL
(https://github.com/imdario/mergo/blob/v1.0.0/LICENSE) with a non-redirecting
URL that returns 200 (for example the raw file URL like
https://raw.githubusercontent.com/imdario/mergo/v1.0.0/LICENSE) in the
NOTICE.txt.tmpl dario.cat/mergo section (version v1.0.0) so automated checks
resolve the license link directly.

{{ range . }}
## {{ .Name }}

Expand Down