feat: Merge node and db postgresql_confs

[GabriellePoncey]

Summary

Merge node-level postgresql_conf with database spec-level postgresql_conf

Changes

• Replaced overridableMapValue with mergableMapValue for PostgreSQLConf, so node-level postgresql.conf settings now merge with the database-level conf rather than replacing it entirely

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d70b2654-6844-4c80-b30f-228393d556e4

📥 Commits

Reviewing files that changed from the base of the PR and between 847bb00 and fc7f4ef.

📒 Files selected for processing (1)

• server/internal/database/spec.go

---

📝 Walkthrough

Walkthrough

NodeInstances() in spec.go now merges database-level and node-level postgresql_conf maps using a new mergableMapValue helper, which clones the base map and overwrites only the keys present in the node-level map, instead of the previous all-or-nothing overridableMapValue behavior.

Changes

PostgreSQL conf map merge strategy

Layer / File(s)	Summary
mergableMapValue helper and NodeInstances() call site server/internal/database/spec.go	Replaces overridableMapValue with mergableMapValue, which clones the base postgresql_conf map and overwrites it with node-level keys rather than substituting the entire map. The PostgreSQLConf field assignment in NodeInstances() is updated to use the new helper.

Poem

A rabbit once hopped through configs so wide,
Where node keys would stomp what the base map supplied.
Now base keys stay put, and the overrides blend,
Each postgresql_conf merged end-to-end.
No aliasing ghosts, just a clone and a merge — 🐇
The map lives in harmony, page after page!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers Summary and Changes sections, but omits Testing, Checklist, and Notes for Reviewers sections required by the template.	Add Testing section with test commands, complete Checklist items, and provide Notes for Reviewers explaining the merging behavior and any migration implications.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: merging node and database postgresql_confs instead of overriding entirely.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/PLAT-625/merge-postgresql_conf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}