faster replication#1166
Open
yogesh1801 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I am still working on the design for it, just a peak if the direction seems well @levkk |
Collaborator
|
Cool! Would be good to see some benchmark numbers, just to get a sense of how much faster this is. |
Contributor
Author
|
Do you have any such setup so that i can benchmark it? |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Collaborator
This might work: Specifically, see |
Contributor
Author
Contributor
Author
Contributor
Author
|
RUNS = 2
@levkk results seems good but also too good at a point |
Collaborator
|
Async should be a big improvement, so not that surprising. This is very cool. Let me know when you're ready for a review, I'll tag Kiryl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



fixes #1036