[4.3.0] [m] Deprecate root jfieldvar - #176
Conversation
resolve phax#173
glelouet
changed the title
| /** | ||
| * @return The owning class. Never <code>null</code>. | ||
| */ | ||
| @Deprecated(forRemoval = true, since = "4.3.0") |
There was a problem hiding this comment.
Well, the method names should not be deprecated - effectively its only the constructor and the class.
There was a problem hiding this comment.
lol, I deprecated the wrong one :P
There was a problem hiding this comment.
actually it's save actions that added deprecated on all public methods. crahp.
There was a problem hiding this comment.
I assumed this. If possible try to turn off that specific save action
There was a problem hiding this comment.
I did it, as you can see the cleanup was changed to have it removed,
120a2a7#diff-9c5202a180f0e1f846ac307a432e16f75b5fcad52a3f396c5bd0d2e6d1b1112eR39
meanwhile I deactivated my "additional actions" because they were conflicting (replacing) the cleanup actions, without a way to have them exported.
There was a problem hiding this comment.
Then you can disable the save action "wrap in paranthesis" as well ;-)
There was a problem hiding this comment.
I disabled all "additional actions" so that the actions are not in duplicate between "clean up" profile and "save actions".
Yeah it's a complete mess, I agree with myself on that.
exported reduced save actions, removed addition of @deprecated on methods in save actions.
|
@phax this one needs to be integrated too. I changed the version to 4.4.0 in case you bump the minor in the next release. If not, revert the last commit after merging. |
|
@phax nooo you missed this one :p |
|
Okay - we will make a 4.4.1 |
2 participants
change minor (require new minor release)
depends (embarks) #175
closes #173