keep inputstream source when generating from the plugin - #186
Merged
Conversation
Now the source responsible is returned in the error
Collaborator
Author
|
sorry, should be draft, I realize the pair is not transmitted to the generator which could use that information |
glelouet
marked this pull request as draft
August 30, 2026 01:51
glelouet
marked this pull request as ready for review
August 30, 2026 02:03
Collaborator
Author
|
I made a PR rather than a discussion for this one. The reason is that I was thinking how to do that before, and how it could help the generators. |
glelouet
changed the title
Owner
|
I have the concept of |
Collaborator
Author
|
Can't find the repo. Can you link @phax ? |
glelouet
changed the title
phax
pushed a commit
that referenced
this pull request
Sep 7, 2026
* maven plugin now concats data and source params streams. Previously, "data" was superseeding the "source" ; now they are both used. If none are present, still returns a Stream.of(null) so that a generator which does not need data would still work (is called against a null inputstream), while a generator that requires data would fail (with NPE) rather than be silently skipped. * keep inputstream source when generating from the plugin (#186) * plugin sources are kept with the inputstream Now the source responsible is returned in the error * sourcedinputstream transmitted to the generators. * activate specific projects formatter and reformat them :P --------- Co-authored-by: glelouet <n@mo> * removed the default build(JCM) since the plugin should never had no data to transmit, no point in this method that was not called to start with. --------- Co-authored-by: glelouet <n@mo>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of getting a stream of inputstream, we also get their source information, if any.
That source information is transmitted down to the generators, so they can use it, eg to deduce class name based on the file.
It is also printed on error, to know which file / url generated the issue.