Conversation
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inverted changelog area-key/title mapping issue
Fix inverted changelog area key/title mapping
Sep 11, 2026
phlax
force-pushed
the
envoy.code.check-changelogs
branch
from
September 11, 2026 13:02
a047f31 to
5450f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog checker and parser were treating
/as the canonical area key and decoding~from entry filenames before lookup. Envoy’s changelog config does the opposite: keys are filename-safe ids using~, titles are display strings using/, and filenames use the key verbatim.Checker: restore canonical key handling
~in area keys and reject/in keys./in titles and reject~in titles via title validation.self.areas.~as filename-only escaping and required slash keys to carry special title handling.Base utils: preserve entry area keys
data_from_entry_map.AREA_SEPARATOR/AREA_FILENAME_SEPARATORhelpers and conversion functions added for the inverted model.Docs and tests
~/dns~careskeys, invaliddns/careskeys, invaliddns~carestitles, direct filename-key matching, and unchanged parsed entry areas.