Add cache CLI options for eslint#1223
Merged
Merged
Conversation
veewee
reviewed
Jun 5, 2026
veewee
left a comment
veewee
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the change.
It looks good, but you'll need to alter the unit tests as well before I can merge.
The new cache and cache_location data sets declared 'stylelint' as the expected binary, so the ProcessBuilder double (configured for 'eslint') returned null and the tests errored.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the cache options for eslint, same as stylelint