updater: PILOT_APP_UPDATE_OPT_OUT app-update opt-out + ship skills-disable opt-out fix#400
Open
Alexgodoroja wants to merge 3 commits into
Open
updater: PILOT_APP_UPDATE_OPT_OUT app-update opt-out + ship skills-disable opt-out fix#400Alexgodoroja wants to merge 3 commits into
Alexgodoroja wants to merge 3 commits into
Conversation
added 2 commits
July 17, 2026 14:19
Bumps skillinject to the commit merged in pilot-protocol/skillinject#31, so the `pilotctl skills disable` opt-out survives `pilotctl update` / `skills check` / installer re-runs. skillinject is compiled into the daemon + pilotctl, so this bump is what ships that fix in a pilotprotocol release.
The pilot-updater keeps installed apps current by periodically running `pilotctl appstore upgrade --all`. Add APP_UPDATE_OPT_OUT=true as the documented way to turn that off — installed apps then stay at the version the operator installed, while the pilot daemon/CLI binaries keep updating. Unset or false (the default) keeps app auto-updates on. Extracts the gate into a testable appAutoUpgradeEnabled() helper following the existing envBool pattern, and keeps PILOT_UPDATER_NO_APP_UPGRADE working as a back-compat alias. Documents the var in the README env-var table and CHANGELOG [1.12.9].
…n from changelog Follow the repo's PILOT_-prefixed env-var convention: the app-update opt-out is now PILOT_APP_UPDATE_OPT_OUT (global boolean, default false). PILOT_UPDATER_NO_APP_UPGRADE stays as the back-compat alias. Moves the changelog entry under [Unreleased] so the release version isn't pinned in the PR.
Alexgodoroja
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App-update opt-out + ship the skills-disable opt-out fix
Two things that need a pilotprotocol release (skillinject is compiled into the
daemon/CLI, so a dependency bump is the only way its fix reaches the fleet).
Added —
PILOT_APP_UPDATE_OPT_OUTpilot-updaterkeeps installed apps current by periodically runningpilotctl appstore upgrade --all. This adds the documented opt-out (a globalboolean):
PILOT_APP_UPDATE_OPT_OUT=truestops the updater from checking for /installing app updates — installed apps stay at the version you installed. Unset
or
false(the default) keeps app auto-updates on. Pilot daemon/CLI binaryupdates are unaffected. Opt back in by removing the var (or setting it false)
and restarting the updater.
PILOT_-prefixed env-var convention.appAutoUpgradeEnabled()helper on the existingenvBoolpattern; keepsPILOT_UPDATER_NO_APP_UPGRADEas a back-compat alias.Fixed — skills-disable opt-out survives updates
Bumps
skillinjectto include pilot-protocol/skillinject#31, sopilotctl skills disableis no longer undone bypilotctl update/skills check/ an installer re-run.Tests
TestAppAutoUpgradeOptOut— default on, every truthy spelling opts out, opt-invalues keep it on, legacy alias still disables.
pilot-updaterlogsapp auto-upgrade opted outwith thevar set and
loop startedwithout it.cmd/...suite green;go build ./...,go vet,go mod tidyclean.