docs: use ticdc-version variable in TiCDC examples (#21911) - #21917
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/ticdc
|
@doc-claw-bot This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughTiCDC 部署示例改用 ChangesTiCDC 版本模板化
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟠 High · up to This change templates TiCDC versions in deployment documentation, but unresolved conflict markers in the version configuration make the configuration invalid and can leave published examples with unresolved placeholders. Resolve the conflict before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: c972816d-21fc-4384-9766-ab0d908aa44a
📒 Files selected for processing (2)
ticdc/ticdc-architecture.mdvariables.json
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| <<<<<<< HEAD | ||
| "tidb-version": "v8.5.0", | ||
| ======= | ||
| "tidb-version": "8.5.8", | ||
| "ticdc-version": "8.5.8", | ||
| >>>>>>> 34087e135a (docs: use ticdc-version variable in TiCDC examples (#21911)) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
删除未解析的合并冲突标记。
<<<<<<< HEAD、======= 和 >>>>>>> ... 使 variables.json 不是合法 JSON。load_variables() 会捕获解析异常并返回空字典，因此 ticdc-version 等模板变量不会被替换，文档产物会保留字面量占位符。请保留 8.5.8 的两个版本值，并删除冲突标记。
建议替换冲突片段
-<<<<<<< HEAD
- "tidb-version": "v8.5.0",
-=======
- "tidb-version": "8.5.8",
- "ticdc-version": "8.5.8",
->>>>>>> 34087e135a (docs: use ticdc-version variable in TiCDC examples (`#21911`))
+ "tidb-version": "8.5.8",
+ "ticdc-version": "8.5.8",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <<<<<<< HEAD | |
| "tidb-version": "v8.5.0", | |
| ======= | |
| "tidb-version": "8.5.8", | |
| "ticdc-version": "8.5.8", | |
| >>>>>>> 34087e135a (docs: use ticdc-version variable in TiCDC examples (#21911)) | |
| "tidb-version": "8.5.8", | |
| "ticdc-version": "8.5.8", |
🧰 Tools
🪛 Biome (2.5.8)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: unexpected character <
(parse)
[error] 3-3: String values must be double quoted.
(parse)
[error] 4-4: End of file expected
(parse)
[error] 4-4: End of file expected
(parse)
[error] 4-4: End of file expected
(parse)
[error] 4-5: End of file expected
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 5-5: unexpected character =
(parse)
[error] 6-6: End of file expected
(parse)
[error] 6-6: End of file expected
(parse)
[error] 6-6: End of file expected
(parse)
[error] 6-6: End of file expected
(parse)
[error] 7-7: End of file expected
(parse)
[error] 7-7: End of file expected
(parse)
[error] 7-7: End of file expected
(parse)
[error] 7-8: End of file expected
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: unexpected character >
(parse)
[error] 8-8: End of file expected
(parse)
[error] 8-8: String values must be double quoted.
(parse)
[error] 8-8: unexpected character (
(parse)
[error] 8-8: String values must be double quoted.
(parse)
[error] 8-8: End of file expected
(parse)
[error] 8-8: Minus must be followed by a digit
(parse)
[error] 8-8: unexpected character (
(parse)
[error] 8-8: unexpected character #
(parse)
[error] 8-8: End of file expected
(parse)
[error] 8-8: unexpected character )
(parse)
[error] 8-8: unexpected character )
(parse)
Source: Linters/SAST tools
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
removed
the
do-not-merge/hold
3 participants
This is an automated cherry-pick of #21911
What is changed, added or deleted? (Required)
ticdc-versiontovariables.jsonticdc/ticdc-architecture.mdwithv{{{ .ticdc-version }}}v8.5.4/v8.5.4-release.1) unchanged and update only example snippets and example commandsWhich TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
文档
配置