Skip to content

release notes, perf-tuning: fix gPRC typo to gRPC - #23604

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
yahonda:fix-gprc-typo-en
Sep 3, 2026
Merged

release notes, perf-tuning: fix gPRC typo to gRPC#23604
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
yahonda:fix-gprc-typo-en

Conversation

@yahonda

@yahonda yahonda commented Aug 26, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes a recurring misspelling of "gRPC" as "gPRC" across several release notes and the performance tuning guide:

  • releases/release-2.0.6.md
  • releases/release-4.0.16.md
  • releases/release-5.0.6.md
  • releases/release-5.1.4.md
  • releases/release-6.1.0.md
  • releases/release-6.1.3.md
  • performance-tuning-methods.md (3 occurrences)

Found while reviewing CodeRabbit feedback on JA translation PR #23599 — the JA translations correctly mirrored this EN typo, so fixing it at the source here instead of diverging the translation.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)

What is the related PR or file link(s)?

N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected multiple occurrences of the “gPRC” typo to “gRPC” across performance documentation and release notes.
    • Clarified references to TiKV latency, Raft log replication, firewall fixes, TiCDC improvements, and gRPC message settings.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 16290d7d-8769-4d19-857f-5908730a7995

📥 Commits

Reviewing files that changed from the base of the PR and between bc98972 and 91e312a.

📒 Files selected for processing (3)
  • releases/release-4.0.16.md
  • releases/release-5.0.6.md
  • releases/release-5.1.4.md
📝 Walkthrough

Walkthrough

The changes correct misspelled gRPC references in one performance document and six release notes. No exported or public entities change.

Changes

Documentation terminology corrections

Layer / File(s) Summary
Performance documentation terminology
performance-tuning-methods.md
Corrects three gPRC references in TiKV latency, Raft log replication, and duration descriptions.
Release note terminology
releases/release-2.0.6.md, releases/release-4.0.16.md, releases/release-5.0.6.md, releases/release-5.1.4.md, releases/release-6.1.0.md, releases/release-6.1.3.md
Corrects six misspelled protocol references in historical firewall, TiCDC, TiKV, and TiDB release notes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bc989

This documentation-only PR corrects gPRC to gRPC across release notes and performance guidance. A minor wording consistency correction remains in three bullets, with no runtime or production impact; the PR is otherwise merge-ready after normal review.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: correcting the recurring “gPRC” typo to “gRPC” in release notes and performance-tuning documentation.
Description check ✅ Passed The description explains the changes, lists the affected files, identifies the applicable version, and records that no special change category applies. It omits the AI agent involvement section, but t…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the changes, lists the affected files, identifies the applicable version, and records that no special change category applies. It omits the AI agent involvement section, but the required information is otherwise complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 57546f99-ca8d-4877-8603-805055adf5da

📥 Commits

Reviewing files that changed from the base of the PR and between ff98075 and bc98972.

📒 Files selected for processing (7)
  • performance-tuning-methods.md
  • releases/release-2.0.6.md
  • releases/release-4.0.16.md
  • releases/release-5.0.6.md
  • releases/release-5.1.4.md
  • releases/release-6.1.0.md
  • releases/release-6.1.3.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread releases/release-4.0.16.md Outdated
yahonda added a commit to yahonda/docs that referenced this pull request Aug 26, 2026
Fixes a recurring misspelling of gRPC across several TiDB/TiCDC/TiKV
release notes and the performance tuning guide.
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-03 04:29:25.256561114 +0000 UTC m=+1340000.427655230: ☑️ agreed by qiancai.

@qiancai qiancai self-assigned this Sep 3, 2026
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Sep 3, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Sep 3, 2026
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 3, 2026
@qiancai

qiancai commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 3, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 0dc31ea into pingcap:master Sep 3, 2026
10 of 11 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #23718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants