i18n(ja): restore DM-master and DM-worker as literal English terms - #23635
Open
yahonda wants to merge 2 commits into
Open
i18n(ja): restore DM-master and DM-worker as literal English terms#23635yahonda wants to merge 2 commits into
yahonda wants to merge 2 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (72)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
14 tasks
qiancai
added
translation/no-need
yahonda
force-pushed
the
fix-dm-master-worker-term-english
branch
from
September 2, 2026 04:35
f2841cb to
ba1acb0
Compare
yahonda
marked this pull request as ready for review
September 2, 2026 04:40
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
yahonda
force-pushed
the
fix-dm-master-worker-term-english
branch
from
September 3, 2026 02:09
ba1acb0 to
ebd971e
Compare
DM-master and DM-worker are the actual TiDB Data Migration (DM) tool component/binary names, matching the dm-master/dm-worker binaries and dm/master, dm/worker paths — not descriptive nouns that should be translated. Unifies the katakana renderings (DMマスター/DMワーカー) to literal DM-master/DM-worker throughout, per the direction already decided. 56 files, 265 sites.
The initial mechanical substitution only matched the no-space form (DMマスター/DMワーカー) and missed the space-separated variant (DM マスター/DM ワーカー), used in ~45 more files. Same fix, same rationale: these are the actual TiDB Data Migration (DM) tool component names, matching the dm-master/dm-worker binaries. 45 files, 200 sites.
yahonda
force-pushed
the
fix-dm-master-worker-term-english
branch
from
September 3, 2026 04:47
ebd971e to
79a030a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
DM-masterandDM-workerare the actual TiDB Data Migration (DM) tool component/binary names (matching thedm-master/dm-workerbinaries anddm/master,dm/workerpaths), not descriptive nouns that should be translated. This corpus rendered them inconsistently as katakanaDMマスター/DMワーカー(and, found on a second pass, the space-separated variantDM マスター/DM ワーカー) in many places while other places already correctly kept them literal (DM-master/DM-worker).This PR unifies all katakana occurrences (both spacing variants) to the literal English form, matching the direction already decided in a prior term-notation review.
DMマスター/DM マスター→DM-masterDMワーカー/DM ワーカー→DM-worker101 files total, 465 sites (265 no-space + 200 space-separated, found on independent review of the first pass). Heading anchors (
{#...}) were already stable English slugs, independent of the visible heading text, so none needed changing.Generic uses of bare マスター/ワーカー (e.g. "master branch", other components) are unrelated to this term and were not touched — only the DM-prefixed forms were in scope.
Verified
markdownlint-cli2clean on all touched files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?