system-variables: add tidb_paging_size_bytes (internal use) (#23565) - #23681
system-variables: add tidb_paging_size_bytes (internal use) (#23565)#23681ti-chi-bot wants to merge 5 commits into
Conversation
ti-chi-bot
added
lgtm
size/S
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughAdds reference documentation for ChangesPaging variable documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🔵 Low · up to This change documents byte-based coprocessor paging, but users may be given an incompatible availability statement or omit a required Resource Group configuration, preventing the feature from working as described. Clarify these prerequisites before merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description includes version and reference sections, but the required change summary is empty. It also selects Resolution Add a concise explanation of the documentation change and its purpose. Select ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a3c708e1-3e4c-4aaf-aa4b-38b6b587c48e
📒 Files selected for processing (1)
system-variables.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
|
||
| - Scope | ||
| - TiDB Self-Managed: SESSION | GLOBAL | ||
| - TiDB Cloud Essential and Premium: SESSION |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
printf '%s\n' '--- applicable conventions ---'
find /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c -path '*/\*.md' -print | sort
printf '%s\n' '--- target entry ---'
sed -n '5398,5424p' system-variables.md
printf '%s\n' '--- resource-control references ---'
rg -n -C 4 'Essential|non-burst|nonburstable|Resource Control|tidb_paging_size_bytes' \
--glob '*.md' \
/tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c system-variables.mdRepository: pingcap/docs
Length of output: 5045
🏁 Script executed:
printf '%s\n' '--- applicable conventions ---'
find /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c -type f -name '*.md' -print | sort
printf '%s\n' '--- target entry ---'
sed -n '5398,5424p' system-variables.md
printf '%s\n' '--- resource-control references ---'
rg -n -C 4 'Essential|non-burst|nonburstable|Resource Control|tidb_paging_size_bytes' \
--glob '*.md' \
/tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c system-variables.mdRepository: pingcap/docs
Length of output: 5310
🏁 Script executed:
printf '%s\n' '--- repository convention ---'
cat /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c/conventions/repo-wide.md
printf '%s\n' '--- resource-control document ---'
resource_doc=$(find . -name 'tidb-resource-control-ru-groups.md' -print -quit)
if [ -n "$resource_doc" ]; then
rg -n -C 5 'Starter|Essential|Premium|fixed RU|non-burst|burstable|Resource Control' "$resource_doc"
else
printf '%s\n' 'resource-control document not present in checkout'
fiRepository: pingcap/docs
Length of output: 7668
Clarify TiDB Cloud Essential availability.
Resource Control is unavailable on TiDB Cloud Essential, but this variable requires Resource Control to take effect. Remove Essential from the scope, or document the internal exception that provides the required Resource Group.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
This is an automated cherry-pick of #23565
What is changed, added or deleted? (Required)
This PR is translated from: pingcap/docs-cn#21752
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Summary by CodeRabbit
tidb_paging_size_bytessystem variable for limiting individual coprocessor response pages by byte size.SET_VARsupport, default value, valid range, and byte unit.