Skip to content

i18n(ja): restore literal English text for user-facing error messages - #23695

Open
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-error-message-english
Open

i18n(ja): restore literal English text for user-facing error messages#23695
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-error-message-english

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Several release notes and reference pages had the actual English error message/string that TiDB (or BR/TiDB Lightning/TiFlash) emits translated into paraphrased Japanese, instead of being kept literal as it appears in EN. Since these are real error strings a user would see verbatim, the Japanese translation should keep them in English too.

Fixed 21 occurrences across 14 files:

  • releases/release-2.0.1.md, release-2.1-rc.2.md, release-3.0.1.md, release-4.0.14.md, release-4.0.15.md (2), release-5.0.0.md, release-5.1.0.md (2), release-5.2.0.md (2), release-5.4.1.md (2), release-6.5.3.md, release-7.1.3.md
  • tidb-lightning/data-import-best-practices.md (4)
  • tikv-configuration-file.md
  • tidb-cloud/serverless-faqs.md

Each fix was verified against the corresponding EN source in release-8.5 to confirm EN itself quotes the literal error text.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated release notes for TiDB versions 2.0.1–7.1.3 to use consistent English error-message terminology.
    • Updated English error wording in TiDB Cloud FAQs, TiDB Lightning import guidance, and TiKV configuration documentation.
    • Refined Japanese documentation wording while preserving the original technical meaning.
    • These are documentation-only changes; configuration behavior and product functionality remain unchanged.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d8ce3c3e-299b-467d-bdd4-717da63fea51

📥 Commits

Reviewing files that changed from the base of the PR and between a82e814 and d8f9ed1.

📒 Files selected for processing (14)
  • releases/release-2.0.1.md
  • releases/release-2.1-rc.2.md
  • releases/release-3.0.1.md
  • releases/release-4.0.14.md
  • releases/release-4.0.15.md
  • releases/release-5.0.0.md
  • releases/release-5.1.0.md
  • releases/release-5.2.0.md
  • releases/release-5.4.1.md
  • releases/release-6.5.3.md
  • releases/release-7.1.3.md
  • tidb-cloud/serverless-faqs.md
  • tidb-lightning/data-import-best-practices.md
  • tikv-configuration-file.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Error message wording updates

Layer / File(s) Summary
Release note error messages
releases/release-*.md
Release notes from TiDB 2.0.1 through 7.1.3 replace Japanese error message translations with English text.
FAQ and troubleshooting terminology
tidb-cloud/serverless-faqs.md, tidb-lightning/data-import-best-practices.md
FAQ headings and TiDB Lightning troubleshooting content use English error messages.
TiKV configuration guidance
tikv-configuration-file.md
The enable-ttl warning uses the English restart error message and revised emphasis.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d8f9e

Japanese documentation now preserves the corresponding English error strings across release notes, troubleshooting, FAQ, and configuration guidance. No behavior, configuration semantics, or documentation links are changed, so the update is ready to merge.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring literal English text for user-facing error messages in Japanese documentation.
Description check ✅ Passed The description explains the change, rationale, affected files, source verification, target documentation version, and AI involvement. The related-link fields are blank, but this is non-critical becau…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, rationale, affected files, source verification, target documentation version, and AI involvement. The related-link fields are blank, but this is non-critical because no specific link is required for this documentation-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (14 skipped: 14 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. area/develop This PR relates to the area of TiDB App development. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda changed the base branch from release-8.5 to i18n-ja-release-8.5 September 2, 2026 02:21
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yahonda
yahonda marked this pull request as ready for review September 2, 2026 02:30
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 2, 2026
@yahonda
yahonda force-pushed the fix-ja-error-message-english branch 2 times, most recently from c8de5ec to bd2c922 Compare September 3, 2026 02:09
yahonda and others added 3 commits September 3, 2026 13:30
Several release notes and reference pages had translated the actual
English error message/string TiDB or its tools emit into paraphrased
Japanese, instead of keeping it literal (matching EN's own quoted
error text). Fixed 21 occurrences across 14 files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
release-5.0.0.md and release-5.1.0.md used TiDB構成 while the
identical templated sentence in release-5.2.0.md already used TiDB
設定, matching the corpus-wide 構成->設定 unification decision.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The second bold span had drifted onto "ください" in the first
sentence instead of marking "使用しないでください" (matching EN's
second **DO NOT**), leaving the actual DO-NOT clause unemphasized.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-error-message-english branch from bd2c922 to d8f9ed1 Compare September 3, 2026 04:31
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants