Skip to content

Add network monitoring module - #820

Closed
kevmo314 wants to merge 2 commits into
mainfrom
kevmo314/netmon
Closed

kevmo314 wants to merge 2 commits into
mainfrom
kevmo314/netmon

Conversation

@kevmo314

@kevmo314 kevmo314 commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Description

Reference issue

Fixes #...

@codecov

codecov Bot commented Oct 6, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.79618% with 233 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.98%. Comparing base (f56f52c) to head (415b683).
⚠️ Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
internal/netmon/monitor_linux.go 28.19% 186 Missing and 5 partials ⚠️
internal/netmon/events.go 0.00% 38 Missing ⚠️
internal/netmon/monitor.go 60.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (25.79%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   86.71%   82.98%   -3.74%     
==========================================
  Files          43       46       +3     
  Lines        4706     5020     +314     
==========================================
+ Hits         4081     4166      +85     
- Misses        448      672     +224     
- Partials      177      182       +5     
Flag Coverage Δ
go 82.98% <25.79%> (-3.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Sean-Der

Sean-Der commented Sep 5, 2026

Copy link
Copy Markdown
Member

@kevmo314 You still interested in merging this? I am cleaning up the backlog

Happy to take over the PR and get it merged!

@kevmo314

kevmo314 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@kevmo314 You still interested in merging this? I am cleaning up the backlog

Happy to take over the PR and get it merged!

Feel free to take over, I think the latest was I didn't have a good way to reliably test/verify it worked on all the different platforms correctly. I only tested on linux iirc

@Sean-Der

Copy link
Copy Markdown
Member

Moved to pion/transport@2b3f0e8

@Sean-Der Sean-Der closed this Sep 21, 2026
@Sean-Der
Sean-Der deleted the kevmo314/netmon branch September 21, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants