Fix resume-cdc.sh to append logs to migration.log#51
Open
teknogeek0 wants to merge 4 commits into
Open
Conversation
With resume-cdc.sh writing to migration.log, check-cdc-status.sh no longer needs its resume-*.log lookup — it silently fell back to migration.log anyway. Read migration.log directly and update the docs, which still described a separate resume-cdc-TIMESTAMP.log (and wrongly attributed resume-*.log to resume-migration.sh).
DmitriiAn
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resume-cdc.shwrote to a freshresume-cdc-<timestamp>.logon every run, sotee -anever actually appended — and, more importantly, that output was a monitoring blind spot:check-migration-status.shandslack-migration-alerts.shwatchmigration.logexclusively, so resume-cdc activity and errors never reached them. This switchesresume-cdc.shtomigration.log, consistent withrun-migration.shandresume-migration.sh, giving one chronological log per migration (each phase writes a timestamped banner).Changes
resume-cdc.sh: log tomigration.loginstead of a per-run timestamped file.check-cdc-status.sh: drop the now-defunctresume-*.loglookup (it silently fell back tomigration.loganyway) and readmigration.logdirectly.AGENTS.md/README.md: update docs that described the old split log — two references also wrongly attributedresume-*.logtoresume-migration.sh, which has always writtenmigration.log.Note
Branch was behind
main; merged it in (no conflicts), which also brings thefind_pgcopydbautodetect already onmainfor this script.