docs: redirect prebuilt archive references to pleaseai/spring-docs - #12
Merged
Merged
Conversation
The prebuilt Markdown archives have moved out of this plugin repository and into a dedicated content repository, pleaseai/spring-docs. Update README to reflect the new home: - /spring:install step 5 now points at spring-docs releases - Plugin structure no longer lists nightly-build.yml (lives in spring-docs); prebuilt/catalog.json reframed as offline mirror - 'Prebuilt archives' section opens with rationale for the split (small plugin clone, independent release cadence, tool-agnostic archives) and references spring-docs as the source of truth - Manual fallback curl URL updated to the new host and tag scheme (<project>-<version>, e.g. framework-6.2.1) - Licensing section points to spring-docs for archive NOTICE attribution and for upstream-maintainer concerns - Related projects gains a spring-docs entry No code or behaviour changes — documentation only. The companion repository was created at https://github.com/pleaseai/spring-docs (commit 2e52a67 there).
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect the migration of prebuilt Markdown archives to a dedicated repository, pleaseai/spring-docs. Key changes include updating repository links, clarifying the separation of content from code, and adjusting the directory structure description to treat local catalogs as offline fallbacks. Feedback was provided to clarify the tag naming convention in the manual download example to prevent ambiguity regarding the spring- prefix in release tags versus asset filenames.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README.md">
<violation number="1" location="README.md:273">
P3: The hint `(tag scheme: <project>-<version>)` is ambiguous: the example tag is `framework-6.2.1` (no `spring-` prefix) while the asset filename is `spring-framework-6.2.1.tar.gz` (with prefix). Users extrapolating to other components (e.g., Spring Boot) won't know whether the tag should be `boot-3.2.0` or `spring-boot-3.2.0`. Consider clarifying that the tag drops the `spring-` prefix, e.g., `(tag scheme: <component>-<version>, e.g., framework-6.2.1)`.</violation>
</file>
Architecture diagram
sequenceDiagram
participant Plugin as Spring Plugin (pleaseai/spring-plugin)
participant DocsRepo as pleaseai/spring-docs
participant GitHub as GitHub Releases
participant SpringUpstream as docs.spring.io
participant Cache as Local Cache (~/.cache/pleaseai-spring/archives/)
Note over Plugin,DocsRepo: Architecture: Plugin code and docs content are now separate repos
Plugin->>Plugin: /spring:install runs
Plugin->>Plugin: Resolve Spring component versions from BOM
alt Prebuilt archive exists in spring-docs
Plugin->>GitHub: Check pleaseai/spring-docs releases for <project>-<version> archive
GitHub-->>Plugin: Release asset URL
Plugin->>Cache: Download and extract archive (~3 seconds)
Cache-->>Plugin: Extracted Markdown skills
else No prebuilt archive
Plugin->>SpringUpstream: Fetch docs from docs.spring.io
SpringUpstream-->>Plugin: HTML documentation
Plugin->>Plugin: Convert Antora HTML to Markdown (~30-60 seconds)
end
Plugin->>Plugin: Install into .claude/skills/spring-<component>/
Plugin->>Plugin: Generate SKILL.md
Note over Plugin,DocsRepo: Offline fallback flow
alt Network unreachable
User->>Cache: Pre-stage archive (downloaded from spring-docs on connected machine)
Cache-->>Plugin: Use local archive from cache
end
Note over DocsRepo,GitHub: Content repo maintains its own release cycle
DocsRepo->>DocsRepo: Build archives nightly from upstream Spring releases
DocsRepo->>GitHub: Publish release with tag <project>-<version>
GitHub-->>GitHub: Host archive with NOTICE (Apache-2.0 license attribution)
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Clarify the tag scheme hint in the manual fallback section after
gemini-code-assist and cubic-dev-ai both flagged the same ambiguity:
the previous hint '<project>-<version>' did not convey that tags drop
the 'spring-' prefix (e.g., 'framework-6.2.1') while asset filenames
retain it ('spring-framework-6.2.1.tar.gz'). Users extrapolating to
other components could not tell whether to use 'boot-3.2.0' or
'spring-boot-3.2.0' for a tag.
Updated hint: '<component>-<version>, e.g., framework-6.2.1' makes
the convention explicit at the point of consumption without forcing
readers to open spring-docs's README.
Co-authored-by: gemini-code-assist[bot] <gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the plugin's
README.mdto reflect the new architecture decision: pre-converted Spring documentation archives now live in a dedicated content repository —pleaseai/spring-docs— rather than being released from this plugin repository.This is a documentation-only change. No code, no behavior, no build changes.
Why
Earlier discussion landed on splitting the plugin code (this repo) from the generated Markdown content (new repo):
git clonestays ~1 MB instead of growing with every Spring releaseCompanion repo bootstrap (LICENSE, NOTICE, README, .gitignore, catalog.json skeleton): https://github.com/pleaseai/spring-docs (commit
2e52a67).Changes (6 surgical edits, single file)
/spring:installstep 5pleaseai/spring-docsreleasesnightly-build.yml(moved to spring-docs); reframeprebuilt/catalog.jsonas an offline mirror of spring-docs's catalogcurlURLpleaseai/spring/releases/spring-framework-6.2.1/...→pleaseai/spring-docs/releases/framework-6.2.1/...(also adopts new tag scheme<project>-<version>)@pleaseai/spring-docsentryStats: +14 / −11 lines, README.md only.
Verification
All 9 hits are intentional cross-references.
Follow-ups (not in this PR)
.please/docs/decisions/0002-docs-repo-split.mdrecording the split decision (referenced as "forthcoming" in the spring-docs README).github.com/pleaseai/springwhile the actual remote ispleaseai/spring-plugin. Pre-existing; not addressed here. Either rename the repo or fix the URLs in a follow-up.pleaseai/spring-docsas a separate track (scripts/,.github/workflows/matrix-build.yml, firstframework-6.2.0Release).Type of change
Summary by cubic
Update README to point all prebuilt Spring docs references to
pleaseai/spring-docsand clarify the manual fallback tag scheme. Docs only; no code or behavior changes.pleaseai/spring-docs.pleaseai/spring-docsand clarified tag scheme to<component>-<version>(e.g.,framework-6.2.1); asset filenames keep thespring-prefix.prebuilt/catalog.jsonas an offline mirror and replacednightly-build.ymlwithci.yml.pleaseai/spring-docs, and added@pleaseai/spring-docsto Related projects.Written for commit bfd8adf. Summary will update on new commits.