Conversation
Lexachoc
force-pushed
the
feature-scatterternarygl
branch
from
September 25, 2026 23:39
6f072c6 to
1d66cc2
Compare
Contributor
Author
|
I’ll add the jasmine tests after the initial review, so I can incorporate any feedback or requested changes first. If there are any specific tests you’d like to see covered, please let me know. One known issue is some visible aliasing/jagged edges in the WebGL rendering. I’ll add a comparison screenshot below to show the difference more clearly. Feedback on whether this should be addressed in this PR would be very helpful. (Same data from the example page: Soil Types Ternary Plot)
|
Contributor
Author
|
It would be helpful if #8041 could be reviewed first, so this PR can also include the ternary spikeline support from that work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #7058
Ternary diagrams are widely used in materials science, for example for glass compositions (shown in #7058) and multicomponent phase diagrams. Platforms such as the Materials Project use interactive Plotly-based phase diagram for multicomponent materials systems.
This PR adds a new
scatterternarygltrace type for rendering ternary scatter plots with WebGL.It reuses the existing
scatterglrendering logic and adds ternary-specific coordinate handling, clipping, hover/select support, strict bundle support, schema/types, regl precompiled commands, tests (to be added), and image mocks.The goal is to provide a WebGL-based alternative to
scatterternary, especially for larger datasets (thousands) showing in #7058.Ternary diagrams are widely used in materials science, for example for glass compositions (as shown in #7058) and multicomponent phase diagrams.
Platforms such as the Materials Project use Plotly-based phase diagrams for multicomponent materials systems, while materials data platforms such as SciGlass Next also work with large glass composition datasets where ternary visualization is very useful.
This PR adds a new
scatterternarygltrace type for rendering ternary scatter plots with WebGL.It reuses the existing
scatterglrendering logic and adds ternary-specific coordinate handling, clipping, hover/select support, strict bundle support, schema/types, regl precompiled commands, tests (to be added), and image mocks.The goal is to provide a WebGL-based alternative to
scatterternary, especially for larger datasets with thousands of points, as shown in #7058.Current limitation
There is no
hoveronattribute forscattergl. Sincescatterternaryglreuses much of thescatterglimplementation, it will not supporthoveroneither. I have no intention of supporting it specifically in this PR, as this should be addressed upstream.