Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
mandocto theapropos .invocation rather than the failingapropos ''one.This was tested on termux's sqlite3-backed mandoc, before this change
qmanwould fail with:'apropos .' failed; did you run mandb/makewhatis?as if it was invoking that, meanwhile the real error was:
$ apropos '' apropos: regcomp //: empty (sub)expressionBecause in reality it was trying to do the other one which is fine on a flat-file mandoc but fails on the sqlite one; passing
qman somemanpagein termux still succeeded without this fix despite the above, but there was no index nor navigable manpages within manpages inside of qman because apropos could not populate it, making it less than ideal to use.The config file changes compared to stock config:
Build instructions for termux:
pip install meson$PREFIXis/data/data/com.termux/files/usr), compile and install qman:qmanand observe it being broken without this or in a less usable state, and fully working with this change.