Setting REDDIT_API_REDIRECT_URI somehow ends up empty string, and therefore login doesn't work

[erkexzcx]

As title suggests, set github secret REDDIT_API_REDIRECT_URI to any value, so non default value is used, and the value becomes empty string. Not using this github secret allowed me to use http://127.0.0.1 which made login within the app work fine, otherwise kept getting Error: Invalid request to Oauth API.

Related issue: #6

[RJGSebastian]

The Problem is that secrets and values derived from secrets cannot be passed as output of a job, this is intended behavior (see this doc). This causes the following error messages:

validate-secrets
Skip output 'giphy_api_key' since it may contain secret.

validate-secrets
Skip output 'redirect_uri' since it may contain secret.

I assume it would cause similar errors if custom values for the keystore are set, but I haven't tested that.

The solution is to just modify the build.yml to set the default variables in the build job, not in the validate-secrets job, preferably this would be done via environment variables. For the giphy key especially it is not even needed to set a default value, since it is only replaced if it is not empty so you can just use secret.GIPHY_API_KEY directly.

Although I have to note that I can still only login with the legacy viewer not with the chrome browser, that still brings an error that the page is not reachable. (With the legacy web view you may have to activate landscape mode for your phone to be able to close the cookie popup else you cannot type in the username and password fields).