Reject zero-sized FIT field definitions with parse context - #41
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I maintain Live Tennis API.
Fixes #40. Reject zero-sized ordinary and developer field definitions immediately with
FitParseError, including the field number and definition offset. Such files already fail in every error mode; this makes that failure actionable and catches it even without a following data message. Positive misaligned fields still use the existing byte fallback, and definitions with no fields remain valid.Validation on Linux:
twine checkpass. The installed wheel handles the issue's 26-byte reproduction in all three modes with offset 14, and still decodes a valid counterpart.fitdecode/exceptions.pyon upstream and this branch.Windows was not tested locally.