Skip to content

Enable gpgcheck in ROCm build scripts #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdeepali merged 6 commits into from
Sep 18, 2026
Merged

Enable gpgcheck in ROCm build scripts #8786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fdcd9ac
Use GPG key for ROCm RPMs
cdeepali Sep 18, 2026
7b0f32a
Add ROCm GPG key
cdeepali Sep 18, 2026
ccf583f
Add ROCm GPG key import and change to dnf
cdeepali Sep 18, 2026
b2895a1
Import ROCm GPG key and switch to dnf
cdeepali Sep 18, 2026
9e2263e
Update and rename vllm_rocm_v0.24.0_ubi_10.sh to vllm_v0.24.0_rocm_ub…
cdeepali Sep 18, 2026
58668b2
Rename build script for version 0.24.0
cdeepali Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions p/pytorch-rocm/pytorch-rocm_2.13.0_ubi_10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,21 @@ if [[ "$ROCM_INSTALL_MODE" == "rpms" ]]; then
fi
echo "Installing ROCm from ${ROCM_REPO_URL}"

ROCM_GPG_URL="https://public.dhe.ibm.com/software/server/POWER/Linux/AMD/RPM-GPG-KEY-PAMD"
ROCM_GPG_PATH="/etc/pki/rpm-gpg/RPM-GPG-KEY-PAMD"
echo "Importing ROCm GPG key from ${ROCM_GPG_URL}"
wget -q -O "${ROCM_GPG_PATH}" "${ROCM_GPG_URL}"
rpm --import "${ROCM_GPG_PATH}"

cat > /etc/yum.repos.d/rocm.repo <<EOF
[ROCm]
name=ROCm
baseurl=${ROCM_REPO_URL}
enabled=1
gpgcheck=0
gpgcheck=1
gpgkey=file://${ROCM_GPG_PATH}
EOF
yum install -y rocm-complete
dnf install -y rocm-complete
ROCM_PATH=/opt/rocm
fi

Expand Down Expand Up @@ -217,4 +224,4 @@ else
echo "$PACKAGE_URL $PACKAGE_NAME"
echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | GitHub | Pass | Both_Install_and_Test_Success"
exit 0
fi
fi
13 changes: 10 additions & 3 deletions t/torchaudio-rocm/torchaudio_2.11.0_rocm_ubi_10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,21 @@ if [[ "$ROCM_INSTALL_MODE" == "rpms" ]]; then
fi
echo "Installing ROCm from ${ROCM_REPO_URL}"

ROCM_GPG_URL="https://public.dhe.ibm.com/software/server/POWER/Linux/AMD/RPM-GPG-KEY-PAMD"
ROCM_GPG_PATH="/etc/pki/rpm-gpg/RPM-GPG-KEY-PAMD"
echo "Importing ROCm GPG key from ${ROCM_GPG_URL}"
wget -q -O "${ROCM_GPG_PATH}" "${ROCM_GPG_URL}"
rpm --import "${ROCM_GPG_PATH}"

cat > /etc/yum.repos.d/rocm.repo <<EOF
[ROCm]
name=ROCm
baseurl=${ROCM_REPO_URL}
enabled=1
gpgcheck=0
gpgcheck=1
gpgkey=file://${ROCM_GPG_PATH}
EOF
yum install -y rocm-complete
dnf install -y rocm-complete
ROCM_PATH=/opt/rocm
fi

Expand Down Expand Up @@ -331,4 +338,4 @@ fi
echo "------------------$PACKAGE_NAME:install_&_test_both_success-------------------------"
echo "$PACKAGE_URL $PACKAGE_NAME"
echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | $OS_NAME | GitHub | Pass | Both_Install_and_Import_Success"
exit 0
exit 0
13 changes: 10 additions & 3 deletions t/torchvision-rocm/torchvision_0.28.0_rocm_ubi_10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,21 @@ if [[ "$ROCM_INSTALL_MODE" == "rpms" ]]; then
fi
echo "Installing ROCm from ${ROCM_REPO_URL}"

ROCM_GPG_URL="https://public.dhe.ibm.com/software/server/POWER/Linux/AMD/RPM-GPG-KEY-PAMD"
ROCM_GPG_PATH="/etc/pki/rpm-gpg/RPM-GPG-KEY-PAMD"
echo "Importing ROCm GPG key from ${ROCM_GPG_URL}"
wget -q -O "${ROCM_GPG_PATH}" "${ROCM_GPG_URL}"
rpm --import "${ROCM_GPG_PATH}"

cat > /etc/yum.repos.d/rocm.repo <<EOF
[ROCm]
name=ROCm
baseurl=${ROCM_REPO_URL}
enabled=1
gpgcheck=0
gpgcheck=1
gpgkey=file://${ROCM_GPG_PATH}
EOF
yum install -y rocm-complete
dnf install -y rocm-complete
ROCM_PATH=/opt/rocm
fi

Expand Down Expand Up @@ -293,4 +300,4 @@ else
echo "$PACKAGE_URL $PACKAGE_NAME"
echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | GitHub | Pass | Both_Install_and_Test_Success"
exit 0
fi
fi
2 changes: 1 addition & 1 deletion v/vllm-rocm/build_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"librocm_smi64.so"
],
"v0.24.0": {
"build_script": "vllm_rocm_v0.24.0_ubi_10.sh"
"build_script": "vllm_v0.24.0_rocm_ubi_10.sh"
},
"v0.28.0": {
"build_script": "vllm_v0.28.0_rocm_ubi_10.sh"
Expand Down
2 changes: 1 addition & 1 deletion v/vllm-rocm/vllm_rocm_v0.24.0_ubi_10.sh → v/vllm-rocm/vllm_v0.24.0_rocm_ubi_10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# configure time.
#
# Usage:
# ./vllm_rocm_v0.24.0_ubi_10.sh [v0.24.0]
# ./vllm_v0.24.0_rocm_ubi_10.sh [v0.24.0]
#
# Environment variables honoured (can be set before running):
# PACKAGE_VERSION - vLLM tag to build (default: v0.24.0)
Expand Down
11 changes: 9 additions & 2 deletions v/vllm-rocm/vllm_v0.28.0_rocm_ubi_10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,21 @@ if [[ "$ROCM_INSTALL_MODE" == "rpms" ]]; then
fi
echo "Installing ROCm from ${ROCM_REPO_URL}"

ROCM_GPG_URL="https://public.dhe.ibm.com/software/server/POWER/Linux/AMD/RPM-GPG-KEY-PAMD"
ROCM_GPG_PATH="/etc/pki/rpm-gpg/RPM-GPG-KEY-PAMD"
echo "Importing ROCm GPG key from ${ROCM_GPG_URL}"
wget -q -O "${ROCM_GPG_PATH}" "${ROCM_GPG_URL}"
rpm --import "${ROCM_GPG_PATH}"

cat > /etc/yum.repos.d/rocm.repo <<EOF
[ROCm]
name=ROCm
baseurl=${ROCM_REPO_URL}
enabled=1
gpgcheck=0
gpgcheck=1
gpgkey=file://${ROCM_GPG_PATH}
EOF
yum install -y rocm-complete
dnf install -y rocm-complete
ROCM_PATH=/opt/rocm
fi

Expand Down
Loading