feat(dpu): DPU out of order streaming replacement based html end stamp - #478
Open
MaxwellCohen wants to merge 1 commit into
Open
feat(dpu): DPU out of order streaming replacement based html end stamp#478MaxwellCohen wants to merge 1 commit into
MaxwellCohen wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 9e6e8b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative DPU template for streaming using an HTML end-stamp comment to let the mutation observer know when to run replacement code. This approach is more targeted and, in theory, more reliable than #474 for race conditions or edge cases, at the cost of slightly more HTML for each boundary of about 9 bytes per resolved suspence boundary resulting in a this sending more html at about 8 boundaries.
code sand box link to use this PR can be seen here
https://ci.codesandbox.io/status/MaxwellCohen/preact-render-to-string/pr/6/builds/691802