Add AliQ80's Reviung41 keymap with dual Arabic (PC/Mac) layers - #128
Open
precondition wants to merge 1 commit into
Open
precondition wants to merge 1 commit into
precondition wants to merge 1 commit into
Conversation
Colemak-DH base with home row mods, combos, and tap dance on a one-piece split Reviung41 (ZMK). Includes a plain "Arabic" layer for the standard PC Arabic layout and a separate "Arabic Mac" layer using mod-morphs to reclaim letters macOS repositions differently. The keymap-drawer SVG only shows raw ZMK keycodes for these two layers (ZMK never transmits Unicode; the OS's active keyboard layout decides the glyph), so the labels were resolved by cross-referencing xkeyboard-config's ara(basic)/ara(mac) tables and overlaid onto the diagram in place, replacing the Latin keycode with the resulting Arabic letter wherever one exists. Diff against the upstream SVG touches only <text> contents, no structural/layout changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new keymap entry for @AliQ80's zmk-config: a Colemak-DH ZMK keymap for the Reviung41 with home row mods, combos, tap dance, and two dedicated Arabic layers ("Arabic" for the standard PC layout, "Arabic Mac" for macOS's differently-positioned Arabic layout)
About the keymap diagram
The
keymap-drawer-generated SVG only shows raw ZMK keycodes (Q,W,E...) for the two Arabic layers, because ZMK never transmits Unicode — it only sends HID keycodes, and the actual Arabic letter depends entirely on which keyboard layout is active on the host OS at the time. I resolved the labels by cross-referencingxkeyboard-config'sara(basic)andara(mac)symbol tables against the keymap's actual bindings (including thekeep-modssemantics of the mod-morphs used in the Mac layer) and overlaid the results directly onto the diagram, replacing the Latin keycode with the resolved Arabic letter wherever a real letter results. The diff against the upstream image touches only<text>contents — no structural/layout changes.@AliQ80 — could you sanity-check the Arabic labels?
Neither of us who worked on this PR reads Arabic, so I'd really appreciate your eyes on AliQ80.svg before it merges, especially the "Arabic Mac" layer's mod-morph shift-outputs, which required interpreting
keep-modsbehavior rather than reading it straight off the keymap:Also worth confirming:
Sft+Kand the tap side ofSft+L(slash_qmark) appear to resolve to nothing under macOS's Arabic layout (that shift-level is explicitly set tonone) — left as their raw ZMK labels since there's no letter to show, but flagging in case that's not intentional on your end.🤖 Generated with Claude Code