Conversation
When requesting MAM catchup, using the exact timestamp of the previously received message as the start date can lead to fetching that same message again. Now we use the unique `stanzaid` of the last message to initiate the catchup with `<after>` so that MAM queries resume strictly after the last received message. A timestamp based offset of one second is preserved strictly as a fallback mechanism for legacy database records that lack a stanza ID. Ref: #2198 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e fetch
When requesting MAM, using the exact timestamp of the previously received message as the start date can lead to fetching that same message again.
Offsetting the start date by one second ensures successive MAM queries resume strictly after the last received message, avoiding duplicate entries.
Fixes: #2198