Conversation
Profanitys in-band account registration path can continue over a raw, unsecured XMPP stream even when the caller selects a mandatory TLS policy. A peer that advertises `jabber:iq:register` but omits `starttls` could cause the registration feature handler to send a registration IQ before TLS is negotiated, exposing user credentials in cleartext. This vulnerability exists because `_register_handle_features` only attempted STARTTLS if the incoming features stanza explicitly included a `<starttls>` child. If that child was absent, the handler immediately checked for registration support and sent the initial registration IQ without verifying whether TLS was mandatory. Reported-by: Jiho Kim <jkim4050@gatech.edu> Reported-by: Team Atlanta Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profanitys in-band account registration path can continue over a raw, unsecured XMPP stream even when the caller selects a mandatory TLS policy. A peer that advertises
jabber:iq:registerbut omitsstarttlscould cause the registration feature handler to send a registration IQ before TLS is negotiated, exposing user credentials in cleartext.This vulnerability exists because
_register_handle_featuresonly attempted STARTTLS if the incoming features stanza explicitly included a<starttls>child.If that child was absent, the handler immediately checked for registration support and sent the initial registration IQ without verifying whether TLS was mandatory.