Stop the vault fixtures looking like real secrets - #23
Merged
Conversation
The OpenCreds test fixtures used an `sk_live_` prefixed token and PEM private-key headers. All placeholders, none real, and the scanners here happened not to fire on them -- but the reference implementation's ThreatCrush run did flag the equivalent strings, and it was right to. A fixture only has to exercise the field. A real-looking live-key prefix or private-key header sitting in the tree trains both the scanner and the people reading its output to shrug at exactly the shape that matters. 149 vault tests still pass, interop included. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRQrfuwuYKKV5UB9kLHuX5
ThreatCrush Security Scan12 finding(s) MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22, which was merged before this commit landed on the branch.
The OpenCreds test fixtures used an
sk_live_prefixed token and PEM private-key headers. All placeholders, none real, and the scanners here happened not to fire on them — but the reference implementation's ThreatCrush run flagged the equivalent strings in profullstack/logicsrc#140, and it was right to.A fixture only has to exercise the field. A real-looking live-key prefix or private-key header sitting in the tree trains both the scanner and the people reading its output to shrug at exactly the shape that matters.
Two test files, six strings. No behaviour change.
Verification
149 vault tests pass, interop against
@logicsrc/opencredsincluded:🤖 Generated with Claude Code
https://claude.ai/code/session_01QRQrfuwuYKKV5UB9kLHuX5